select: fix processing storage error for tuple-merger #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
approved these changes
Apr 8, 2022
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-271-select-nil-err-merger
branch
from
4078cfc to
5831f4b
Compare
AnaNek
approved these changes
Apr 8, 2022
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-271-select-nil-err-merger
branch
from
5831f4b to
8004e0e
Compare
Storage select/pairs method responds with `nil, err` if something went wrong. tuple-merger implementation of select/pairs do not support this type of response, resulting in fail while trying to subscribe nil value. The patch fixes this behavior by extracting second return value in case of `nil, err` and wrapping it with errors wrapper to restore errors metatable. Closes #271
DifferentialOrange
force-pushed
the
DifferentialOrange/gh-271-select-nil-err-merger
branch
from
8004e0e to
3abc35d
Compare
|
UPD: wrap net.box error to restore |
olegrok
approved these changes
Apr 8, 2022
Totktonada
approved these changes
Apr 8, 2022
DifferentialOrange
deleted the
DifferentialOrange/gh-271-select-nil-err-merger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage select/pairs method responds with
nil, errif something wentwrong. tuple-merger implementation of select/pairs do not support this
type of response, resulting in fail while trying to subscribe nil value.
The patch fixes this behavior by extracting second return value in case
of
nil, errand wrapping it with errors wrapper to restore errorsmetatable.
Closes #271
I didn't forget about