Skip to content

Conversation

@pgulutzan
Copy link
Contributor

The first commit has the wrong version number; the second commit should fix that.

@github-actions github-actions bot temporarily deployed to branch-pgulutzan-gh-2185 July 13, 2021 22:46 Inactive
@github-actions github-actions bot temporarily deployed to translation-pgulutzan-gh-2185 July 13, 2021 22:46 Inactive
@github-actions github-actions bot temporarily deployed to translation-pgulutzan-gh-2185 July 13, 2021 22:50 Inactive
@github-actions github-actions bot temporarily deployed to branch-pgulutzan-gh-2185 July 13, 2021 22:51 Inactive
IPROTO_BALLOT_GC_VCLOCK may have the value of the instance's oldest
WAL entry, which corresponds to :ref:`box.info.gc().vclock <box_info_gc>`.

IPROTO_BALLOT_RO is true if the instance is not writable,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPROTO_BALLOT_RO -> IPROTO_BALLOT_IS_RO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Yes. Changed now. Thanks.

@github-actions github-actions bot temporarily deployed to translation-pgulutzan-gh-2185 July 16, 2021 14:19 Inactive
@github-actions github-actions bot temporarily deployed to branch-pgulutzan-gh-2185 July 16, 2021 14:22 Inactive
@patiencedaur patiencedaur self-assigned this Jul 20, 2021
Co-authored-by: Patience Daur <40490252+patiencedaur@users.noreply.github.com>
IPROTO_BALLOT_IS_RO_CFG and IPRO_BALLOT_VCLOCK and IPROTO_BALLOT_GC_VCLOCK and IPROTO_BALLOT_IS_RO
were added in version :doc:`2.6.1 </release/2.6.1>`.
IPROTO_BALLOT_IS_ANON was added in version :doc:`2.7.1 </release/2.7.1>`.
IPROTO_BALLOT_IS_BOOTED was added in version 2.7.3 and 2.8.2 and 2.9.1.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are not released yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an improvement to change "IPROTO_BALLOT_GC_VCLOCK may have the value" to "IPROTO_BALLOT_GC_VCLOCK can be the clock value", yes.

It's true that "These versions are not released yet." In fact the changes have been done already. However, in #2185, in response to the question "@Gerold103 Since which Tarantool version we have these changes?", the answer was "2.9.1, 2.8.2, 2.7.3". I understood this to mean that these are the versions that we should mention.

were added in version :doc:`2.6.1 </release/2.6.1>`.
IPROTO_BALLOT_IS_ANON was added in version :doc:`2.7.1 </release/2.7.1>`.
IPROTO_BALLOT_IS_BOOTED was added in version 2.7.3 and 2.8.2 and 2.9.1.
There have been some name changes starting with version 2.7.3 and 2.8.2 and 2.9.1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are not released yet.

@github-actions github-actions bot temporarily deployed to translation-pgulutzan-gh-2185 July 20, 2021 12:50 Inactive
@github-actions github-actions bot temporarily deployed to branch-pgulutzan-gh-2185 July 20, 2021 12:52 Inactive
@github-actions github-actions bot temporarily deployed to translation-pgulutzan-gh-2185 July 20, 2021 16:21 Inactive
@github-actions github-actions bot temporarily deployed to branch-pgulutzan-gh-2185 July 20, 2021 16:21 Inactive
@github-actions github-actions bot temporarily deployed to translation-pgulutzan-gh-2185 August 12, 2021 10:00 Inactive
@github-actions github-actions bot temporarily deployed to branch-pgulutzan-gh-2185 August 12, 2021 10:00 Inactive
@alexandra-mara alexandra-mara merged commit 4f5559c into latest Aug 12, 2021
@alexandra-mara alexandra-mara deleted the pgulutzan-gh-2185 branch August 12, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants