-
Notifications
You must be signed in to change notification settings - Fork 43
Fixes gh-2185 IPROTO_BALLOT rework and a new field #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| IPROTO_BALLOT_GC_VCLOCK may have the value of the instance's oldest | ||
| WAL entry, which corresponds to :ref:`box.info.gc().vclock <box_info_gc>`. | ||
|
|
||
| IPROTO_BALLOT_RO is true if the instance is not writable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPROTO_BALLOT_RO -> IPROTO_BALLOT_IS_RO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Yes. Changed now. Thanks.
Co-authored-by: Patience Daur <40490252+patiencedaur@users.noreply.github.com>
| IPROTO_BALLOT_IS_RO_CFG and IPRO_BALLOT_VCLOCK and IPROTO_BALLOT_GC_VCLOCK and IPROTO_BALLOT_IS_RO | ||
| were added in version :doc:`2.6.1 </release/2.6.1>`. | ||
| IPROTO_BALLOT_IS_ANON was added in version :doc:`2.7.1 </release/2.7.1>`. | ||
| IPROTO_BALLOT_IS_BOOTED was added in version 2.7.3 and 2.8.2 and 2.9.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions are not released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an improvement to change "IPROTO_BALLOT_GC_VCLOCK may have the value" to "IPROTO_BALLOT_GC_VCLOCK can be the clock value", yes.
It's true that "These versions are not released yet." In fact the changes have been done already. However, in #2185, in response to the question "@Gerold103 Since which Tarantool version we have these changes?", the answer was "2.9.1, 2.8.2, 2.7.3". I understood this to mean that these are the versions that we should mention.
| were added in version :doc:`2.6.1 </release/2.6.1>`. | ||
| IPROTO_BALLOT_IS_ANON was added in version :doc:`2.7.1 </release/2.7.1>`. | ||
| IPROTO_BALLOT_IS_BOOTED was added in version 2.7.3 and 2.8.2 and 2.9.1. | ||
| There have been some name changes starting with version 2.7.3 and 2.8.2 and 2.9.1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions are not released yet.
The first commit has the wrong version number; the second commit should fix that.