Document SQL_EXPR #3643
Merged
Document SQL_EXPR #3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyaksenov
force-pushed
the
sql-expr-func
branch
from
f307eb5 to
a65890c
Compare
andreyaksenov
force-pushed
the
sql-expr-func
branch
9 times, most recently
from
e9c06bf to
01206cf
Compare
ImeevMA
approved these changes
Sep 4, 2023
ImeevMA
left a comment
ImeevMA
left a comment
There was a problem hiding this comment.
Hi! Thank you for the patch. I have three comments, but they are all minor and can be ignored.
Also, I didn't mention it, but it would be nice to add that SQL_EXPR functions can be created when creating a SQL CHECK constraint using SQL. Moreover, if the above constraint is dropped, the SQL_EXPR function is not removed, which may not be obvious.
| t.assert_equals(age_err:unpack().message, 'Check constraint \'check_person\' failed for tuple') | ||
| t.assert_equals(name_err:unpack().message, 'Check constraint \'check_person\' failed for tuple') | ||
| end) | ||
| end No newline at end of file |
| box.schema.func.create('check_person', { | ||
| language = 'SQL_EXPR', | ||
| is_deterministic = true, | ||
| body = [["age" > 21 AND "name" !='Admin']] |
There was a problem hiding this comment.
It might be better to add space between != and Admin.
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Constraints use stored Lua functions, which must return ``true`` when the constraint | ||
| Constraints use stored Lua functions or :ref:`SQL expressions <sql_expressions>`, which must return ``true`` when the constraint |
There was a problem hiding this comment.
Not sure it's worth mentioning that the Lua and SQL_EXPR functions can be used as constraints. For example, C functions can also be used as constraints. Maybe not mention it here?
andreyaksenov
force-pushed
the
sql-expr-func
branch
from
01206cf to
d38bb61
Compare
xuniq
approved these changes
Sep 12, 2023
Contributor
xuniq
left a comment
xuniq
left a comment
There was a problem hiding this comment.
The new structure seems good to me.
Comment on lines
18
to
19
| Using the :ref:`body <function_options_body>` option, you can make a function "persistent". | ||
| In this case, the function is "persistent" because its definition is stored in a snapshot (the :ref:`box.space._func <box_space-func>` system space) and can be recovered if the server restarts. |
Contributor
There was a problem hiding this comment.
Suggested change
| Using the :ref:`body <function_options_body>` option, you can make a function "persistent". | |
| In this case, the function is "persistent" because its definition is stored in a snapshot (the :ref:`box.space._func <box_space-func>` system space) and can be recovered if the server restarts. | |
| Using the :ref:`body <function_options_body>` option, you can make a function *persistent*. | |
| In this case, the function is persistent because its definition is stored in a snapshot (the :ref:`box.space._func <box_space-func>` system space) and can be recovered if the server restarts. |
|
|
||
| Whether the function should be executed in an isolated environment. | ||
| This means that any operation that accesses the world outside the sandbox is forbidden or has no effect. | ||
| Therefore a sandboxed function can only use modules and functions |
Contributor
There was a problem hiding this comment.
Suggested change
| Therefore a sandboxed function can only use modules and functions | |
| Therefore, a sandboxed function can only use modules and functions |
andreyaksenov
force-pushed
the
sql-expr-func
branch
from
d38bb61 to
c38bb41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function_optionstable description. The function description now contains the SQL_EXPR example for a tuple constraint. The language attribute description is extended with the newSQL_EXPRvalue.