Rework histogram buckets process

[DifferentialOrange]

ipairs should be there if we want to check up if array is sorted, not pairs

metrics/metrics/collectors/histogram.lua

Line 12 in a2d783e

for k, v in pairs(buckets) do

[ochaton]

Debatable! pairs actually iterates through numeric part firstly (like ipairs does), and only then iterate through keys. You may replace pairs with ipairs only when you manage to guarantee that table buckets contains only numeric part.

for k, v in pairs(buckets) do
        if type(k) ~= 'number' then return false end
        if type(v) ~= 'number' then return false end
        if v <= 0 then return false end
        if prev > v then return false end
        prev = v
end

[DifferentialOrange]

Debatable! pairs actually iterates through numeric part firstly (like ipairs does), and only then iterate through keys. You may replace pairs with ipairs only when you manage to guarantee that table buckets contains only numeric part.

for k, v in pairs(buckets) do
        if type(k) ~= 'number' then return false end
        if type(v) ~= 'number' then return false end
        if v <= 0 then return false end
        if prev > v then return false end
        prev = v
end

Lua documentation (https://www.lua.org/pil/7.3.html) states that

The pairs function, which iterates over all elements in a table, is similar [to ipairs], except that the iterator function is the next function ...
The call next(t, k), where k is a key of the table t, returns a next key in the table, in an arbitrary order.

Even if the effect in fact is the same, I don't see any reason to use pairs instead of ipairs since we deal with an array here.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days