Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- be gentle to http routes, don't leave gaps in the array
[#246](https://github.com/tarantool/metrics/issues/246)
- allow to create summary without observations [#265](https://github.com/tarantool/metrics/issues/265)

### Added
- `tnt_clock_delta` metric to compute clock difference on instances
Expand Down
8 changes: 5 additions & 3 deletions metrics/collectors/summary.lua
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ function Summary:new(name, help, objectives, params)
obj.age_buckets_count = params.age_buckets_count or 1
obj.observations = {}

obj.quantiles = {}
for q, _ in pairs(objectives) do
table.insert(obj.quantiles, q)
if obj.objectives then
obj.quantiles = {}
for q, _ in pairs(objectives) do
table.insert(obj.quantiles, q)
end
end
return obj
end
Expand Down
16 changes: 16 additions & 0 deletions test/collectors/summary_test.lua
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,22 @@ g.test_summary_wrong_label = function()
instance.observe, instance, 1, {quantile = 0.5})
end

g.test_create_summary_without_observations = function()
local ok, summary = pcall(metrics.summary, 'plain_summary')
t.assert(ok, summary)
summary:observe(0)

local summary_metrics = utils.find_metric('plain_summary_count', metrics.collect())
t.assert_equals(#summary_metrics, 1)

summary_metrics = utils.find_metric('plain_summary_sum', metrics.collect())
t.assert_equals(#summary_metrics, 1)

summary_metrics = utils.find_metric('plain_summary', metrics.collect())
t.assert_not(summary_metrics)

end

local test_data_wrong_input = {
objectives = {error = 'Invalid value for objectives', input = {'summary', nil, {0.5, 0.9, 0.99}}},
max_age = {error = 'Max age must be positive', input = {'summary', nil, {[0.5]=0.01}, {max_age_time = -1}}},
Expand Down