code health: don't mix FAILURE and -1 in get_spaceno_by_name() #168
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically we should return FAILURE (not -1) from the changed function
in case of a failure. FAILURE is -1 in fact and it unlikely will be
changed, but the only formal guarantee we have is that FAILURE is a
negative value.
Cited from [1]:
| typedef enum {
| SUCCESS = 0,
| FAILURE = -1, /* this MUST stay a negative number, or it may affect functions! */
| } ZEND_RESULT_CODE;
No behaviour actually changed in this commit.
It is the follow up for 5647d24 ('Fix
select() by space_no and index_name'), where we initially set eyes on
this point.
[1]: https://github.com/php/php-src/blob/4903f7c5fde11a115f659ec54a1d0ede6fd7232c/Zend/zend_types.h#L53-L56
Follows up #42.
LeonidVas
approved these changes
Jul 17, 2020
Totktonada
deleted the
Totktonada/gh-42-select-space-no-index-name-follow-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically we should return FAILURE (not -1) from the changed function
in case of a failure. FAILURE is -1 in fact and it unlikely will be
changed, but the only formal guarantee we have is that FAILURE is a
negative value.
Cited from 1:
No behaviour actually changed in this commit.
It is the follow up for 5647d24 ('Fix
select() by space_no and index_name'), where we initially set eyes on
this point.
Follows up #42.