Remove luatest and checks submodules #454
Conversation
The `test-run` project is rarely updated these days while `luatest` is rapidly developing. Let's remove the `luatest` submodule from `test-run` to ease luatest bumps in projects using `test-run`. Now, `luatest` is supposed to be added as a submodule to all projects using `test-run`. By default, `test-run` looks for `luatest` in `../third_party/luatest`, but this can be overridden with the new `--luatestdir option`. Note that we also remove the `checks` submodule, which was added as a dependency of `luatest`. It was built in Tarantool in 2.11.0 so there's no need in it anymore. Closes #453
|
We can't remove the submodules because they are needed for integration tests. I think I'll leave them be and instead allow to specify a custom luatest directory. |
|
We still can do it, just add |
| parser.add_argument( | ||
| "--luatestdir", | ||
| dest="luatestdir", | ||
| default="../third_party/luatest", |
There was a problem hiding this comment.
Can we search it using LUA_PATH by default?
I mean, we don't need the bin/luatest wrapper (it just makes things more complicated for us in the case), we can just do tarantool -e 'require('luatest.cli_entrypoint')()'.
There was a problem hiding this comment.
I think, we don't ever need this --luatestdir argument or env variable. Just correctly configured lua paths.
There was a problem hiding this comment.
The thing is I don't want to setup LUA_PATH when running tests in Tarantool with test-run.py. I just want everything to work by default, without any extra parameters or environment variables. Moreover, I'd like test-run.py --env to setup LUA_PATH so that I can run tests with luatest.
There was a problem hiding this comment.
In other words, yes, we could require developers to setup luatest by themselves for running Tarantool tests, but (a) this would be inconvenient and (b) could result in non-obvious errors caused by using an old version of luatest. Better checkout luatest as a submodule in Tarantool and make test-run use it automatically IMO.
Yep, that'd probably be better than leaving the TBH I find these tests useless because we check that |
|
Superseded by: |
The
test-runproject is rarely updated these days whileluatestis rapidly developing. Let's remove theluatestsubmodule fromtest-runto ease luatest bumps in projects usingtest-run. Now,luatestis supposed to be added as a submodule to all projects usingtest-run.By default,
test-runlooks forluatestin../third_party/luatest, but this can be overridden with the new--luatestdir option.Note that we also remove the
checkssubmodule, which was added as a dependency ofluatest. It was built in Tarantool in 2.11.0 so there's no need in it anymore.Closes #453