Fix arguments parsing if internal command is forced over external #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/gh-1134-parse-arguments-if-internal-forced-over-external
branch
from
cfbcfc8 to
b8b58ae
Compare
| rc, output = run_command_and_get_output(cmd, cwd=tmp_path) | ||
| rc, output = utils.run_command_and_get_output(cmd, cwd=tmp_path) | ||
| assert rc == 0 | ||
| assert re.match(r"(\d+.\d+.\d+|<unknown>)", output) |
Contributor
There was a problem hiding this comment.
Suggested change
| assert re.match(r"(\d+.\d+.\d+|<unknown>)", output) | |
| assert re.match(r"(\d+.\d+.\d+$|<unknown>)", output) |
Contributor
Author
There was a problem hiding this comment.
Applied in separate commit (but $ is injected at the end of regexp to be applied to <unknown> as well).
oleg-jukovec
approved these changes
Mar 31, 2025
patapenka-alexey
approved these changes
Apr 1, 2025
elhimov
force-pushed
the
elhimov/gh-1134-parse-arguments-if-internal-forced-over-external
branch
2 times, most recently
from
d04b7c3 to
020ffb1
Compare
Closes #1134 @TarantoolBot document Title: Fix arguments parsing if internal command is forced over external
elhimov
force-pushed
the
elhimov/gh-1134-parse-arguments-if-internal-forced-over-external
branch
from
020ffb1 to
5677812
Compare
dmyger
deleted the
elhimov/gh-1134-parse-arguments-if-internal-forced-over-external
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguments of an internal command are not parsed if it is forced over its existent external counterpart.
I didn't forget about:
Related issues:
Closes #1134