Skip to content

Conversation

@askalt
Copy link
Contributor

@askalt askalt commented Jun 20, 2023

tt install tarantool-dev has been added.

Made it via symlink to an existing tarantool binary.
The binary file is searched in 2 paths taken from
tarantool and tarantool-ee.

Besides, if tarantool was installed without headers directory,
some commands (e.g. tt rocks, tt build) may not work properly,
so the include-dir option has been added to specify this directory.

Also, there are changes in the modules binaries, uninstall.
The logic of recognition of the installed tarantool-dev has been added
to the binaries.
For uninstall the tarantool-dev deletion logic has been added, which
removes the executable symlink and the symlink to the headers directory.

Closes #429

@TarantoolBot document
Title: abitilty to install tarantool from the local build directory

Now, one can add a pseudo-installation of tarantool, which will point
to the executable file in the local build directory,
and then use this installation with tt run command.
For example:

make -j16 -C ~/src/tarantool/build
tt install tarantool-dev ~/src/tarantool/build
tt run # runs the binary compiled above

@askalt askalt added the full-ci Enables full ci tests label Jun 20, 2023
@askalt askalt requested a review from LeonidVas June 20, 2023 13:47
@LeonidVas LeonidVas requested a review from better0fdead June 22, 2023 08:51
Copy link
Contributor

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thx for patch. Have some comments.
Pls, add a check that directory exists.
Pls, add an integration test for "tt install tarantool-dev".

@askalt askalt force-pushed the askalt/gh-429-install-tarantool-from-src branch 4 times, most recently from 127a0f3 to 6fa872f Compare June 26, 2023 09:02
@askalt askalt requested a review from better0fdead June 26, 2023 09:12
Copy link
Contributor

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psergee
Copy link
Contributor

psergee commented Jul 3, 2023

Thanks for the patch.
Please, check how tt binaries and tt build/tt rocks install (no system-wide tarantool installed) commands work with tarantool-dev binary "installed".

@LeonidVas LeonidVas requested review from psergee and removed request for LeonidVas July 4, 2023 09:57
@askalt askalt force-pushed the askalt/gh-429-install-tarantool-from-src branch 2 times, most recently from e45e939 to dd1d035 Compare July 6, 2023 14:24
@askalt
Copy link
Contributor Author

askalt commented Jul 6, 2023

Sample scenario with tarantool-dev:
proof of work 2

@askalt askalt requested a review from better0fdead July 6, 2023 14:27
@askalt askalt force-pushed the askalt/gh-429-install-tarantool-from-src branch from dd1d035 to 9ec6dca Compare July 6, 2023 16:02
@askalt askalt force-pushed the askalt/gh-429-install-tarantool-from-src branch 8 times, most recently from 08d45b6 to a7e659b Compare July 10, 2023 05:19
Copy link
Contributor

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@askalt askalt force-pushed the askalt/gh-429-install-tarantool-from-src branch 2 times, most recently from 3fdb302 to cbcd1ac Compare July 10, 2023 11:48
Removed '--use-docker' flag from 'tt uninstall tarantool'
since it was added by mistake.

Closes #501
@askalt askalt force-pushed the askalt/gh-429-install-tarantool-from-src branch from cbcd1ac to 7e8a736 Compare July 10, 2023 13:06
@psergee psergee merged commit f6ea220 into master Jul 10, 2023
@psergee psergee deleted the askalt/gh-429-install-tarantool-from-src branch July 10, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables full ci tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to install tarantool from local source tree

4 participants