Rename workflow file to avoid precommit/Makefile collision #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collision I noted in CI run https://github.com/target/make-python-devex/actions/runs/9387484385/job/25850507307 that the Makefile pre-commit check was picking up makefile.yml as a Makefile. This rename avoids that. ``` Makefile linter/analyzer.................................................Failed - hook id: checkmake - exit code: 6 RULE DESCRIPTION FILE NAME LINE NUMBER minphony Missing required phony target .github/workflows/makefile.yml 0 "all" minphony Missing required phony target .github/workflows/makefile.yml 0 "clean" minphony Missing required phony target .github/workflows/makefile.yml 0 "test" phonydeclared Target "name" should be .github/workflows/makefile.yml 1 declared PHONY. phonydeclared Target "on" should be declared .github/workflows/makefile.yml 3 PHONY. phonydeclared Target "jobs" should be .github/workflows/makefile.yml 9 declared PHONY. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noted in CI run https://github.com/target/make-python-devex/actions/runs/9387484385/job/25850507307 that the Makefile pre-commit check was picking up makefile.yml as a Makefile. This rename avoids that.