Windows support #11
Windows support #11
Conversation
lib/git-hooks.js
Outdated
There was a problem hiding this comment.
backslash, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String
without it will be '....\node_modules\git-hooks\lib\git-hooks'
aliosv
force-pushed
the
windows-support
branch
from
c9f70a5 to
2de692e
Compare
There was a problem hiding this comment.
Using execSync for executing npm test is a bad idea because the script can reach buffer limit. Moreover, execSync doesn't proxy any output during execution; so, a user watches nothing but an empty screen. It's a bad UX.
There was a problem hiding this comment.
exec().stdout.on('data') resolves problem. There is error occur if i spawn npm(npm enoent).
|
When the solution is summarized in #10, the pull request (or another one) will be opened . |
|
Anyone looking for Windows support should check out Husky. It's a very active project which allows you to set up git hooks in your package.json file. It supports OSX, linux and Windows and has support for a few other hooks which git-hooks-js does not. |
No description provided.