Skip to content
This repository was archived by the owner on Feb 20, 2020. It is now read-only.

Conversation

@petemoore
Copy link
Member

See bug 1486800 for details.

@petemoore petemoore self-assigned this Oct 2, 2018
@coveralls
Copy link

coveralls commented Oct 2, 2018

Coverage Status

Coverage decreased (-0.02%) to 70.038% when pulling ee68050 on bug1486800 into e82c1e6 on master.

@petemoore petemoore requested a review from imbstack October 3, 2018 18:24
Copy link
Contributor

@imbstack imbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

main.go Outdated

func (task *TaskRun) setMaxRunTimer() *time.Timer {
return time.AfterFunc(
// Round(0) forces wall time calculation instead of monotonic time in case machine slept etc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can delete this comment now?

@petemoore petemoore merged commit 4827917 into master Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants