Skip to content
This repository was archived by the owner on Mar 1, 2019. It is now read-only.

Conversation

djmitche
Copy link
Contributor

With a few related, forward-looking changes..

@djmitche djmitche self-assigned this May 22, 2018
@djmitche djmitche requested a review from tomprince May 22, 2018 20:51
Copy link
Contributor

@tomprince tomprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, modulo the concerns about the name from mozreview.

const result = {};
await Promise.all(Object.entries(projects).map(async ([alias, {repo, features}]) => {
// try repos don't have a `default` so there's nothing to do
if (alias.startsWith('try') || alias.endsWith('try')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the should be part of the config, rather than looking at the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - I'd like to solve that another time :)

@djmitche djmitche merged commit 2685b3f into master May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants