Skip to content
This repository was archived by the owner on Jan 5, 2019. It is now read-only.

Conversation

@djmitche
Copy link
Contributor

@djmitche djmitche commented May 3, 2018

No description provided.

@djmitche djmitche requested review from imbstack and jonasfj May 3, 2018 19:21
Copy link
Contributor

@imbstack imbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a nit and then r+

config.yml Outdated
emailBlacklist: !env:json EMAIL_BLACKLIST
# ignore tasks with reasonResolved matching something in this list
ignoreTaskReasonResolved:
- cancelled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is spelled with one l in taskcluster apparently!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is apparently the American way, so I guess we can't blame @jonasfj :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch BTW, your review skills are legion :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only noticed because I had just reviewed a jonas patch where it was spelled canceled and I thought, "that's a weird spelling". I was going to tell him he was wrong until I checked the docs :p

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is weird because we have two americans here who spell it the wrong way apparently.

@djmitche djmitche merged commit 7696236 into taskcluster:master May 3, 2018
@jonasfj
Copy link
Contributor

jonasfj commented May 3, 2018

@djmitche I would have bit this option on task.extra.notify instead...

@jonasfj
Copy link
Contributor

jonasfj commented May 3, 2018

Just in case you misunderstood my comment in the bug..

@djmitche
Copy link
Contributor Author

djmitche commented May 3, 2018

I feel like that's as messy as putting it in the routes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants