-
Notifications
You must be signed in to change notification settings - Fork 8
Bug 1455698 - implement configuration for wihch reasonResolved to ignore #31
Conversation
imbstack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix a nit and then r+
config.yml
Outdated
| emailBlacklist: !env:json EMAIL_BLACKLIST | ||
| # ignore tasks with reasonResolved matching something in this list | ||
| ignoreTaskReasonResolved: | ||
| - cancelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is spelled with one l in taskcluster apparently!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is apparently the American way, so I guess we can't blame @jonasfj :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome catch BTW, your review skills are legion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only noticed because I had just reviewed a jonas patch where it was spelled canceled and I thought, "that's a weird spelling". I was going to tell him he was wrong until I checked the docs :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is weird because we have two americans here who spell it the wrong way apparently.
|
@djmitche I would have bit this option on task.extra.notify instead... |
|
Just in case you misunderstood my comment in the bug.. |
|
I feel like that's as messy as putting it in the routes. |
No description provided.