Skip to content

fix: make IndexSearch optimization log reasons why it may refuse to u… #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: make IndexSearch optimization log reasons why it may refuse to u… #524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3ea98
fix: make IndexSearch optimization log reasons why it may refuse to u…
bhearsum Jun 20, 2024
9b5e89c
style: pre-commit.ci auto fixes [...]
pre-commit-ci[bot] Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/taskgraph/optimize/strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,17 @@ def should_replace_task(self, task, params, deadline, arg):
# status can be `None` if we're in `testing` mode
# (e.g. test-action-callback)
if not status or status.get("state") in ("exception", "failed"):
logger.debug(
f'not replacing {task["label"]} with {task_id} because it is in failed or exception state'
)
continue

if deadline and datetime.strptime(
status["expires"], self.fmt
) < datetime.strptime(deadline, self.fmt):
logger.debug(
f'not replacing {task["label"]} with {task_id} because it expires before {deadline}'
)
continue

return task_id
Expand Down