feat(init): use versioned decision image #528
Conversation
jcristau
force-pushed
the
template-versioned-decision
branch
from
e68cdd2 to
6286086
Compare
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "project_name": "my-project", | |||
| "taskgraph_version": "{{ cookiecutter.taskgraph_version }}", | |||
There was a problem hiding this comment.
I don't think this will work. The template context comes from the other variables in this file, so this seems like it would lead to some kind of recursion error?
Instead this is supposed to contain the default value we use for this key in case cookiecutter is ran with interactive mode disabled. That being said, I don't think we should prompt for this value anyway. Instead we should either use latest or the same version as what they are running taskgraph init with.
There was a problem hiding this comment.
Yeah I'm not sure, I was going from https://cookiecutter.readthedocs.io/en/stable/advanced/injecting_context.html which seems to be doing something similar?
There was a problem hiding this comment.
On second thought, we should definitely use the same version as what they ran taskgraph init with. Otherwise, the generated graph might fail inside the Decision task.
There was a problem hiding this comment.
Oh, I think I missed the extra context being passed in there. And thanks for the link.
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "project_name": "my-project", | |||
| "taskgraph_version": "{{ cookiecutter.taskgraph_version }}", | |||
There was a problem hiding this comment.
Oh, I think I missed the extra context being passed in there. And thanks for the link.
2 participants
Fixes #493