Skip to content

Conversation

@jcristau
Copy link
Contributor

POST requests aren't retried by default, because they may not be idempotent. However both find_task_id_batched and status_task_batched are read-only so there's no reason not to retry.

POST requests aren't retried by default, because they may not be
idempotent.  However both find_task_id_batched and status_task_batched
are read-only so there's no reason not to retry.
@jcristau
Copy link
Contributor Author

A couple of things:

  • as far as I can tell there's no test coverage for the batched requests
  • we may want to audit all other calls to _do_request and decide that retrying all POSTs is safe

@jcristau jcristau marked this pull request as ready for review June 28, 2024 13:33
@jcristau jcristau merged commit 40dff3b into taskcluster:main Jun 28, 2024
@jcristau jcristau deleted the retry-batched branch June 28, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants