fix: ensure strip_components and add_prefix are respected in repack_archive #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #591 I implemented a new function should_repack_archive that aimed to improve the robustness of renaming files while preserving the preexisting logic of when to repack an archive in a fetch task.
Unfortunately, I left an outer if-statement that leaves one edge case in which the behavior is slightly changed.
Whenever
args.strip_componentsorargs.add_prefixis defined, we are supposed to repack the archive regardless, however the new logic stays to do it only if the files are not the same.The logic is correct within the new function, but the outer if-statement needs to be removed.