Skip to content

Conversation

@RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Oct 16, 2024

Description

  • What does this PR change? Give us a brief description.

I would like to summarize and explain the use of menu

The following problems will be solved:

  • rust
  • one level menu, two (multiple) levels of settings.
  • custom menu items.
  • menu event handling.
  • reset (how to change menu status/language/etc.)
  • Menu Event
  • accelerator (forget why)
  • JavaScript
  • one level menu, two (multiple) levels of settings.
  • custom menu items.
  • menu event handling.
  • reset (how to change menu status/language/etc.)
  • Menu Event
  • accelerator

I will refer to:

If anyone has any questions about the use of menu, please add them below. I will try my best to enrich the documentation on using menu.

@netlify
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c1887d6
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/67a57b7c9e3c030008d480d3
😎 Deploy Preview https://deploy-preview-2875--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@RSS1102
Copy link
Contributor Author

RSS1102 commented Nov 20, 2024

waitting tauri-apps/tauri#11741 release.

@RSS1102 RSS1102 marked this pull request as ready for review January 17, 2025 18:49
@RSS1102 RSS1102 requested a review from a team as a code owner January 17, 2025 18:49
@RSS1102
Copy link
Contributor Author

RSS1102 commented Jan 17, 2025

@RSS1102 RSS1102 marked this pull request as draft January 18, 2025 19:08
@RSS1102 RSS1102 marked this pull request as ready for review January 19, 2025 13:25
Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up, left some suggestions. I haven't tested the code, I trust that you did. Overall this should be enough. Thanks again. Ah, this page fits better under /learn. I guess, as window menu is part of Tauri Core.

@vasfvitor
Copy link
Contributor

vasfvitor commented Jan 20, 2025

also I'm thinking if somehow this can be split into more logical sections and not only top level headings, not sure it's possible, just an idea
image

more like this
image

@RSS1102 RSS1102 marked this pull request as draft January 22, 2025 20:04
@RSS1102
Copy link
Contributor Author

RSS1102 commented Feb 7, 2025

also I'm thinking if somehow this can be split into more logical sections and not only top level headings, not sure it's possible, just an idea image

more like this image

Maybe I will optimize this in the future, but it seems that I am delayed by other things and I don’t have the energy to re-plan all the code at the moment. But I will keep it in mind and optimize it later.

@vasfvitor
Copy link
Contributor

@RSS1102 it's ok, I can merge already and it can be improved later, what do you think?

@RSS1102 RSS1102 marked this pull request as ready for review February 7, 2025 03:12
@RSS1102
Copy link
Contributor Author

RSS1102 commented Feb 7, 2025

@RSS1102 it's ok, I can merge already and it can be improved later, what do you think?

ok,In the next stage, I will synchronize the Chinese version first.
And then I will make an improvement (when my time permits).

@vasfvitor vasfvitor merged commit fdd2a6c into tauri-apps:v2 Feb 7, 2025
9 checks passed
@vasfvitor
Copy link
Contributor

thank you for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants