This issue refers to issue #9, to create student medical history schema. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hitansh159
suggested changes
Apr 12, 2023
models/std_med_history.js
Outdated
| @@ -0,0 +1,14 @@ | |||
| import { Schema } from 'mongoose'; | |||
Contributor
There was a problem hiding this comment.
no need for this import
models/std_med_history.js
Outdated
| import { Schema } from 'mongoose'; | ||
| import { connector } from './databaseUtil'; | ||
|
|
||
| const studentMedicalSchema= new Schema({ |
Contributor
There was a problem hiding this comment.
studentMedicalSchema will be just a object no need for new Schema
Contributor
There was a problem hiding this comment.
restore it to its previous state
TejasNair9977
requested changes
Apr 13, 2023
Member
TejasNair9977
left a comment
TejasNair9977
left a comment
There was a problem hiding this comment.
other than these changes, it looks good to me
models/std_med_history.js
Outdated
| bloodGroup:{type:String, required:true}, | ||
| pastMedicalHistory:{type:String, required:true}, | ||
| immunisationHistory:{type:String, required:true}, | ||
| chronicMedicalConditions:{type:String, required:true}, |
models/std_med_history.js
Outdated
Comment on lines
9
to
10
| parentsContact:{type:String, required:true}, | ||
| relativeContacts:{type:String, required:true}, |
Member
There was a problem hiding this comment.
can you make these contact fields as numbers
models/std_med_history.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| import { connector } from './databaseUtil'; | |||
|
|
|||
| const studentMedicalSchema=({ | |||
Member
There was a problem hiding this comment.
remove the extra brackets
Hitansh159
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.