Skip to content

Conversation

@hricha11
Copy link
Contributor

@hricha11 hricha11 commented Sep 3, 2023

Description

Create all endpoints for organization

Fixes

fixes #250

Checklist

  • Code follows project's style guidelines.
  • Changes are documented appropriately.

Copy link
Contributor

@sumitst05 sumitst05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@@ -0,0 +1,60 @@
import {
addNewOrganization, deleteOrganizationById, updateOrganizationById, getOrganization,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function to get organization as defined in services/organization.js is named getOrganizations and not getOrganization


async function showOrganization(req, res) {
try {
const organization = await getOrganization(req.query);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change getOrganization to getOrganizations here as well

async function deleteOrganization(req, res) {
const { organizationId } = req.params;
try {
await deleteOrganizationById(accredationId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change accreditationId to organizationId

@TejasNair9977 TejasNair9977 linked an issue Sep 3, 2023 that may be closed by this pull request
Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TejasNair9977 TejasNair9977 merged commit a3005b3 into development Sep 9, 2023
@TejasNair9977 TejasNair9977 deleted the 250-endpoints-for-organization branch October 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] Create all endpoints for organization

5 participants