-
-
Notifications
You must be signed in to change notification settings - Fork 40
250 Create all endpoints for organization #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sumitst05
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested.
controller/organization.js
Outdated
| @@ -0,0 +1,60 @@ | |||
| import { | |||
| addNewOrganization, deleteOrganizationById, updateOrganizationById, getOrganization, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function to get organization as defined in services/organization.js is named getOrganizations and not getOrganization
controller/organization.js
Outdated
|
|
||
| async function showOrganization(req, res) { | ||
| try { | ||
| const organization = await getOrganization(req.query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change getOrganization to getOrganizations here as well
controller/organization.js
Outdated
| async function deleteOrganization(req, res) { | ||
| const { organizationId } = req.params; | ||
| try { | ||
| await deleteOrganizationById(accredationId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change accreditationId to organizationId
…into 250-endpoints-for-organization
TejasNair9977
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TejasNair9977
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Create all endpoints for organization
Fixes
fixes #250
Checklist