[Mega-Feat]: Implement Group Endpoints #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruvrg
reviewed
Sep 13, 2023
test/routes/group.test.js
Outdated
| title: "Group 1", | ||
| student: "64fdc67feca8a69f01b33614", | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
check content-type for post and update operations is it is json or not
eg :- expect(response.headers["content-type"]).toMatch(/json/);
refer accreditation.test.js
Contributor
Author
There was a problem hiding this comment.
Whoops! missed that...
Added the necessary checks now :)
Thanks...
Dhruvrg
reviewed
Sep 13, 2023
|
|
||
| function cleanUp(callback) { | ||
| groupModel | ||
| .remove({ |
Member
There was a problem hiding this comment.
you should pass only id as parameter in remove(delete) operation not with title because in group models we are taking only groupId as input
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Group endpoints to the project. It includes the following changes:
app.jsFixes
#314
Checklist