Skip to content

[woof]: Add husky to manage precommit hooks #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2023
Merged

[woof]: Add husky to manage precommit hooks #401

merged 3 commits into from
Oct 14, 2023

Conversation

@sumitst05
Copy link
Contributor

@sumitst05 sumitst05 commented Oct 14, 2023

Description

This PR replaces the previously setup pre-commit hook with the new one that has been set up using husky and lint-staged.

Fixes

#398

Checklist

  • Code follows project's style guidelines.
  • Changes are documented appropriately.

Notes

  • Existing hook for pre-commit is now redundant and thus, ./hooks and setup.js have been removed.
  • New directory that contains pre-commit script is .husky/pre-commit.

TejasNair9977
TejasNair9977 approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TejasNair9977 TejasNair9977 merged commit bf61cac into development Oct 14, 2023
@TejasNair9977 TejasNair9977 deleted the 398-add-husky branch October 15, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TejasNair9977 TejasNair9977 TejasNair9977 approved these changes

@kskarthik05 kskarthik05 Awaiting requested review from kskarthik05

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sumitst05 @TejasNair9977