Skip to content

Feat : 430 Adds validation before creating a new Student #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Feat : 430 Adds validation before creating a new Student #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions controller/student.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,33 @@ import {
updateStudentById,
} from "#services/student";
import { logger } from "#util";
import { isEntityIdValid } from "#middleware/entityIdValidation";
import Department from "#models/department";
import Course from "#models/course";

async function addStudent(req, res) {
const { ERPID, name, joiningYear, branch, division, rollNo, coursesOpted } =
req.body;
try {
const newStudent = await createStudent(
ERPID,
name,
joiningYear,
branch,
division,
rollNo,
coursesOpted,
);
res.json({ res: `added user ${newStudent.id}`, id: newStudent.id });
const isBranchValid = await isEntityIdValid(branch, Department);
const isCourseValid = await isEntityIdValid(coursesOpted, Course);
if (isBranchValid && isCourseValid) {
const newStudent = await createStudent(
ERPID,
name,
joiningYear,
branch,
division,
rollNo,
coursesOpted,
);
res.json({ res: `added user ${newStudent.id}`, id: newStudent.id });
} else {
var error = "";
if (!isBranchValid) error.concat('Invalid branch');
if (!isCourseValid) error.concat(' Invalid course opted');
res.status(400).json({ err: error });
}
} catch (error) {
logger.error("Error while inserting", error);
res.status(500);
Expand Down