Skip to content

[ADDED]Added validation for module. #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[ADDED]Added validation for module. #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b64db
[added]
deepti-50 Nov 4, 2023
eb4bf72
Updated module.js
deepti-50 Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions controller/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import {
deleteModuleById,
} from "#services/module";
import { logger } from "#util";
import { isEntityIdValid } from "#middleware/entityIdValidation";
import Topic from "#models/topic";

async function showModule(req, res) {
try {
Expand All @@ -21,15 +23,20 @@ async function showModule(req, res) {

async function addModule(req, res) {
const { no, name, contents, hrsPerModule, cognitiveLevels } = req.body;
const isTopicValid = await isEntityIdValid(contents, Topic);
try {
const newModule = await addNewModule(
no,
name,
contents,
hrsPerModule,
cognitiveLevels,
);
res.json({ res: `added module ${newModule.name}` });
if (isTopicValid) {
const newModule = await addNewModule(
no,
name,
contents,
hrsPerModule,
cognitiveLevels,
);
res.json({ res: `added module ${newModule.name} ${newModule.id}` });
} else {
res.status(400).json({ err: "Invalid name" , err: "Invalid id"});
}
} catch (error) {
logger.error("Error while inserting", error);
res.status(500);
Expand Down