Skip to content

[FEAT] Creating ERPID for Student and Faculty #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2023
Merged

[FEAT] Creating ERPID for Student and Faculty #466

merged 2 commits into from
Dec 27, 2023

Conversation

@Aastha-S-Rai
Copy link
Contributor

@Aastha-S-Rai Aastha-S-Rai commented Dec 19, 2023

Description

  • shifted departmentAbbrev and departmentNames arrays in constants
  • added logic for creating erpId for student and faculty
  • updated testcases for student and faculty i.e removed ERPID that was given manually

Fixes

#415

Checklist

  • Code follows project's style guidelines.

@Aastha-S-Rai Aastha-S-Rai removed the request for review from TejasNair9977 December 27, 2023 11:17
TejasNair9977
TejasNair9977 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TejasNair9977 TejasNair9977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aastha-S-Rai Aastha-S-Rai merged commit 8eed790 into development Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TejasNair9977 TejasNair9977 TejasNair9977 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aastha-S-Rai @TejasNair9977