-
-
Notifications
You must be signed in to change notification settings - Fork 40
Performed Crud on AccreditationModel #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TejasNair9977
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes.
models/accreditation.js
Outdated
| }; | ||
|
|
||
| const AccreditationModel = new connector.model('Accreditation', accreditationSchema); | ||
| const Accreditation = new connector.model('Accreditation', accreditationSchema); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename this back to AccreditationModel
models/accreditation.js
Outdated
|
|
||
| export default AccreditationModel; | ||
| async function remove(filter) { | ||
| const res = await Accreditation.findOneAndDelete(filter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this change in every line under it too
models/accreditation.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| import connector from "#models/databaseUtil"; | |||
| import { logger } from "#util"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove logger
models/accreditation.js
Outdated
| import connector from "#models/databaseUtil"; | ||
| import { logger } from "#util"; | ||
|
|
||
| connector.set("debug", true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove debug as well
TejasNair9977
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #49