Skip to content

Conversation

@nichenqin
Copy link
Contributor

No description provided.

@nichenqin nichenqin requested a review from tea-artist October 21, 2025 01:07
@nichenqin nichenqin force-pushed the feat/conditional-lookup-max-limit branch from bc8e1f6 to 204f534 Compare October 21, 2025 01:17
@coveralls
Copy link
Collaborator

coveralls commented Oct 21, 2025

Pull Request Test Coverage Report for Build 18671183429

Details

  • 66 of 72 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 75.1%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/field/open-api/field-open-api.service.ts 61 67 91.04%
Totals Coverage Status
Change from base Build 18652446693: 0.006%
Covered Lines: 50155
Relevant Lines: 66784

💛 - Coveralls

@tea-artist
Copy link
Contributor

we might need an ENV to hard limit the max lookup items length.

@nichenqin
Copy link
Contributor Author

we might need an ENV to hard limit the max lookup items length.

https://github.com/teableio/teable/pull/2008/files#diff-97eb559a60618e0f69aef917c5aeda5ac473b50636e759a45328402b9fe93dffR10-R14
I'm using env to set max limit

@nichenqin nichenqin merged commit e6dcd59 into develop Oct 21, 2025
13 checks passed
@nichenqin nichenqin deleted the feat/conditional-lookup-max-limit branch October 21, 2025 04:31
@github-actions
Copy link

🧹 Preview Environment Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants