feat: add support s3 custom domain #2014

boris-w · 2025-10-21T10:23:46Z

No description provided.

Copilot

Pull Request Overview

This PR adds support for custom domain endpoints for S3 private buckets, allowing URLs to be rewritten to use a configured custom domain instead of the default S3 endpoint.

Introduces a new configuration parameter privateBucketEndpoint for custom domain support
Implements URL replacement logic to swap S3 endpoints with custom domains
Updates internal operations to consistently use s3ClientPrivateNetwork instead of s3Client

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
apps/nestjs-backend/src/features/attachments/plugins/s3.ts	Adds `replaceBucketEndpoint` method, applies URL replacement to presigned URLs, switches internal S3 operations to use private network client, adds debug logging
apps/nestjs-backend/src/configs/storage.ts	Adds `privateBucketEndpoint` configuration parameter from environment variable

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-21T10:25:00Z

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

+  private replaceBucketEndpoint(url: string, bucket: string): string {
+    const { privateBucketEndpoint, privateBucket } = this.config;
+    if (privateBucketEndpoint && bucket === privateBucket) {
+      const resUrl = new URL(url, privateBucketEndpoint);


The second parameter of URL constructor is intended to be a base URL for relative paths. However, url is already an absolute URL from getSignedUrl. This will cause the privateBucketEndpoint to be ignored. Remove the second parameter and create two separate URL objects.

Suggested change

const resUrl = new URL(url, privateBucketEndpoint);

const resUrl = new URL(url);

Copilot · 2025-10-21T10:25:00Z

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

      };
      // eslint-disable-next-line @typescript-eslint/no-explicit-any
    } catch (e: any) {
+      console.log('S3 presigned error', e);


Debug console.log should be replaced with proper logging using a logger service. Console logs are not appropriate for production code and don't support log levels or structured logging.

Copilot · 2025-10-21T10:25:01Z

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

    });
+    return this.replaceBucketEndpoint(res, bucket);
  }
  uploadFileWidthPath(


Corrected spelling of 'Width' to 'With' in method name.

Copilot · 2025-10-21T10:25:01Z

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

    filePath: string,
    metadata: Record<string, unknown>
  ) {
+    console.log('start uploadFileWidthPath', bucket, path, filePath, metadata);


Debug console.log should be replaced with proper logging using a logger service. Console logs are not appropriate for production code and don't support log levels or structured logging.

Copilot · 2025-10-21T10:25:01Z

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

      .finally(() => {
        readStream.removeAllListeners();
        readStream.destroy();
+        console.log('end uploadFileWidthPath');


Debug console.log should be replaced with proper logging using a logger service. Console logs are not appropriate for production code and don't support log levels or structured logging.

tea-artist · 2025-10-21T10:34:48Z

apps/nestjs-backend/src/configs/storage.ts

  publicUrl: process.env.BACKEND_STORAGE_PUBLIC_URL,
  publicBucket: process.env.BACKEND_STORAGE_PUBLIC_BUCKET || 'public',
  privateBucket: process.env.BACKEND_STORAGE_PRIVATE_BUCKET || 'private',
+  privateBucketEndpoint: process.env.BACKEND_STORAGE_PRIVATE_BUCKET_ENDPOINT,


add example and doc for this .env

coveralls · 2025-10-21T10:48:58Z

Pull Request Test Coverage Report for Build 18744952466

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

7 of 134 (5.22%) changed or added relevant lines in 4 files are covered.
306 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.006%) to 75.084%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apps/nestjs-backend/src/features/attachments/plugins/storage.ts	2	3	66.67%
apps/nestjs-backend/src/features/attachments/plugins/aliyun.ts	3	53	5.66%
apps/nestjs-backend/src/features/attachments/plugins/s3.ts	0	76	0.0%

Files with Coverage Reduction	New Missed Lines	%
apps/nestjs-backend/src/features/attachments/plugins/s3.ts	1	0.79%
apps/nestjs-backend/src/features/record/computed/services/computed-dependency-collector.service.ts	6	94.25%
apps/nestjs-backend/src/features/record/query-builder/providers/pg-record-query-dialect.ts	7	88.28%
apps/nestjs-backend/src/features/data-loader/resource/table-common-loader.ts	9	35.0%
apps/nestjs-backend/src/features/view/view.service.ts	29	91.24%
apps/nestjs-backend/src/features/record/query-builder/field-cte-visitor.ts	41	75.86%
apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts	82	76.86%
apps/nestjs-backend/src/features/record/record.service.ts	131	88.18%

Totals
Change from base Build 18680464543:	-0.006%
Covered Lines:	50358
Relevant Lines:	67069

💛 - Coveralls

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/nestjs-backend/src/features/attachments/plugins/aliyun.ts

apps/nestjs-backend/src/features/attachments/plugins/s3.ts

github-actions · 2025-10-23T13:04:50Z

🧹 Preview Environment Cleanup

PR feat: add support s3 custom domain #2014 has been Merged
Preview environment has been deleted
Cleanup time: 2025-10-23T13:04:50.341Z

* feat: add support s3 custom domain * chore: remove log code and env example * refactor: use AWS official method for S3 custom domain * feat: support aliyun oss * feat: debug s3 sockets connection count * chore: safe isNaN

feat: add support s3 custom domain

e1d55cd

boris-w requested review from Copilot and tea-artist October 21, 2025 10:23

Copilot AI reviewed Oct 21, 2025

View reviewed changes

tea-artist reviewed Oct 21, 2025

View reviewed changes

boris-w added 2 commits October 22, 2025 11:55

chore: remove log code and env example

28c8694

refactor: use AWS official method for S3 custom domain

5290713

boris-w requested a review from Copilot October 22, 2025 09:32

Copilot AI reviewed Oct 22, 2025

View reviewed changes

apps/nestjs-backend/src/features/attachments/plugins/s3.ts Show resolved Hide resolved

feat: support aliyun oss

396765d

boris-w requested a review from Copilot October 22, 2025 10:09

Copilot AI reviewed Oct 22, 2025

View reviewed changes

apps/nestjs-backend/src/features/attachments/plugins/s3.ts Show resolved Hide resolved

apps/nestjs-backend/src/features/attachments/plugins/s3.ts Show resolved Hide resolved

feat: debug s3 sockets connection count

9af7ffb

boris-w requested a review from Copilot October 23, 2025 08:55

Copilot AI reviewed Oct 23, 2025

View reviewed changes

apps/nestjs-backend/src/features/attachments/plugins/aliyun.ts Show resolved Hide resolved

apps/nestjs-backend/src/features/attachments/plugins/s3.ts Outdated Show resolved Hide resolved

apps/nestjs-backend/src/features/attachments/plugins/s3.ts Show resolved Hide resolved

chore: safe isNaN

339c542

boris-w merged commit 09fe334 into develop Oct 23, 2025
13 checks passed

boris-w deleted the feat/s3-support-custom-domain branch October 23, 2025 13:04

	const resUrl = new URL(url, privateBucketEndpoint);
	const resUrl = new URL(url);

Uh oh!

feat: add support s3 custom domain #2014

feat: add support s3 custom domain #2014

Uh oh!

Conversation

boris-w commented Oct 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

tea-artist Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 18744952466

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2025

🧹 Preview Environment Cleanup

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Oct 21, 2025 •

edited

Loading