Skip to content

Conversation

@mattvagni
Copy link
Member

@mattvagni mattvagni commented May 12, 2023

This PR adds generated documentation using https://typedoc.org/ and documents some other basics manually in the readme. The documentation leaves a lot to be desired but as a first pass I think this is usable.

👉 This also makes the package public 👈 so that anyone and everyone can install this.

As a next step I will add all the queries and mutations and such that are missing!

@vercel
Copy link

vercel bot commented May 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-sdk ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 2:11pm


### Patch Changes

- 24abeea: Add support for upserting customers.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the changelog here since these releases were just to set up and test the release process with changesets.

Copy link
Member Author

@mattvagni mattvagni May 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this release onwards these will actually make sense / be real.

@mattvagni mattvagni marked this pull request as ready for review May 14, 2023 09:24
@mattvagni mattvagni changed the title WIP: SDK Docs Documentation May 14, 2023
/* Handled mutation errors */
type MutationError = {
code: 'mutation_error';
type: 'mutation_error';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed these to type so they are not confused with our error codes!


**[Documentation](https://plain-typescript-sdk-docs.vercel.app/classes/PlainSDKClient.html)**

If you would like to add a query or mutation please open an issue and we can add it for you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you would like to add a query or mutation please open an issue and we can add it for you.
If you would like to add support for a query or mutation please open an issue and we can add it for you.

Also, instead of we can add it for you, might as well suggest that they can open a PR and we'll review it, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the API reference to check for other available queries/mutations? https://docs.plain.com/core-api/reference

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, instead of we can add it for you, might as well suggest that they can open a PR and we'll review it, no?

No contributing guidelines yet!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the API reference to check for other available queries/mutations? https://docs.plain.com/core-api/reference

I don't want to do this since that page is not very useful and if you are not familiar with GraphQL it's very confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to make that better one day though

Co-authored-by: Jesus <jesus@plain.com>
Co-authored-by: Jesus <jesus@plain.com>
Co-authored-by: Jesus <jesus@plain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants