Add support for fetching and resolving issues #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mattvagni
commented
Jul 10, 2023
| ### UnknownError | ||
|
|
||
| [(view source)](./src/error.ts) | ||
| Fallback error type when something unexpected happens. |
Member
Author
There was a problem hiding this comment.
Realised this was missing from the readme so I documented this as well!
mattvagni
commented
Jul 10, 2023
| "rollup-plugin-esbuild": "^5.0.0", | ||
| "typedoc": "^0.24.7", | ||
| "typedoc-plugin-missing-exports": "^2.0.0", | ||
| "typescript": "^5.1.6", |
Member
Author
There was a problem hiding this comment.
Had to install typescript since pnpm is a lot stricter than npm (which is a good thing)
jesushernandez
approved these changes
Jul 10, 2023
jordrake
reviewed
Jul 10, 2023
| * Resolve an issue for a customer. | ||
| */ | ||
| async resolveIssue( | ||
| input: VariablesOf<typeof ResolveIssueDocument>['input'] |
Contributor
There was a problem hiding this comment.
This feels a little 'raw' for an SDK, this could just be issueId and we construct the input
Member
Author
There was a problem hiding this comment.
That is what it is but just as a named argument (notice the 'input' at the end):
This means this is valid:
const foo = await client.resolveIssue({
issueId: 'it_123'
})
Member
Author
There was a problem hiding this comment.
Or did you mean: resolveIssue('asda') would be nicer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this I've also moved all CI to use node 18 and pnpm.