feat(master): support all device orientations on iOS #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkness
reviewed
Oct 22, 2019
| "portrait", | ||
| "portrait-upside-down", | ||
| "landscape" | ||
| ]} |
Contributor
|
Sorry could you also create this off the hooks branch - im yet to merge and release hooks. Will do with this update. |
Contributor
Author
|
The hooks version is #13.
Would you like it to be defined through props and the have the array of all
options as the fallback?
…On Tue, 22 Oct 2019 at 17:58, Henry ***@***.***> wrote:
Sorry could you also create this off the hooks branch - im yet to merge
and release hooks. Will do with this update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14?email_source=notifications&email_token=AAR7NBSRSELNU3V65VVFOI3QP4WKZA5CNFSM4JDSONBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6OUQQ#issuecomment-545057346>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR7NBSGPBCFIPTDXJ26OTDQP4WKZANCNFSM4JDSONBA>
.
|
Contributor
Author
|
#14 (comment): close in favour of #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12