Skip to content

Add debug configuration for running cli in vscode#559

Closed
JrGoodle wants to merge 2 commits intopkgxdev:mainfrom
JrGoodle:mojoe/vscode-debug-configuration
Closed

Add debug configuration for running cli in vscode#559
JrGoodle wants to merge 2 commits intopkgxdev:mainfrom
JrGoodle:mojoe/vscode-debug-configuration

Conversation

@JrGoodle
Copy link
Contributor

I didn't see anything in the docs about how to debug run in vscode so I messed around a bit and got it kind of working. For some reason it adds deno as an arg and the symlink check makes it get appended which causes problems. I'm not sure what the current symlink check is for, so could use some guidance there. It seems to hang and never finish, but I haven't looked into that yet.

@what-the-diff
Copy link

what-the-diff bot commented Apr 29, 2023

PR Summary

  • New configuration for launch.json
    Added a new configuration to improve the launch setup
  • Updated README with extension and installation info
    Enhanced the README with information about the VSCode extension and Homebrew installation for Deno
  • Bug fix in args parsing
    Resolved a bug that caused failure in parsing arguments when the executable had specific naming formats, by using target instead of link

@JrGoodle JrGoodle force-pushed the mojoe/vscode-debug-configuration branch from c42d401 to a39dd72 Compare April 29, 2023 17:18
@coveralls
Copy link

coveralls commented Apr 29, 2023

Coverage Status

Coverage: 77.113% (+0.009%) from 77.103% when pulling a39dd72 on JrGoodle:mojoe/vscode-debug-configuration into 31c2fc0 on teaxyz:main.

@JrGoodle JrGoodle closed this May 3, 2023
@JrGoodle JrGoodle reopened this May 4, 2023
const basename = link.basename()
// const isSymlink = link.isSymlink()
if (basename == "deno") return
// if (basename == "deno" && !isSymlink) return // deno is literally executing our source code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this about?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary to get it debuggable in vscode or?

@mxcl mxcl force-pushed the main branch 2 times, most recently from 732a370 to 36d64bc Compare May 11, 2023 15:00
@mxcl
Copy link
Contributor

mxcl commented Jun 7, 2023

Closing, reopen if you can help.

@mxcl mxcl closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants