Add debug configuration for running cli in vscode#559
Closed
JrGoodle wants to merge 2 commits intopkgxdev:mainfrom
Closed
Add debug configuration for running cli in vscode#559JrGoodle wants to merge 2 commits intopkgxdev:mainfrom
JrGoodle wants to merge 2 commits intopkgxdev:mainfrom
Conversation
PR Summary
|
c42d401 to
a39dd72
Compare
mxcl
reviewed
May 9, 2023
| const basename = link.basename() | ||
| // const isSymlink = link.isSymlink() | ||
| if (basename == "deno") return | ||
| // if (basename == "deno" && !isSymlink) return // deno is literally executing our source code |
Contributor
There was a problem hiding this comment.
is this necessary to get it debuggable in vscode or?
732a370 to
36d64bc
Compare
Contributor
|
Closing, reopen if you can help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't see anything in the docs about how to debug run in vscode so I messed around a bit and got it kind of working. For some reason it adds
denoas an arg and the symlink check makes it get appended which causes problems. I'm not sure what the current symlink check is for, so could use some guidance there. It seems to hang and never finish, but I haven't looked into that yet.