WIP: Tests for GitLab Backend #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `parseJsonResponse` - Errors on non-ok responses for text responses as well as JSON responses - Adds an optional `meta` field to `APIError` in `src/valueObjects/errors/APIError.js` - Passes github error responses to `APIErrors` generated by `request` in `API.js` of github backend
Functions refactored: - `storeMetadata` - `composeFileTree` - `persistFiles` - `uploadBlob` These refactors had to be done together, since each the methods refactored had implicit dependencies on mutations made by the others. Specifically, `composeFileTree` and `uploadBlob` had to be called in a specific order to mutate their arguments correctly. This led to a race condition in `persistFiles` that was (fortunately) only affecting debugging. This commit removes the mutation and makes the functions more independent, in addition to making general readability and code length improvements to the affected functions. `composeFileTree` has also had its filtering of uploaded files removed, as that was a concern better handled by the caller.
them. This is not optimal, but it is how the GitHub implementation works and should be fixed later.
tech4him1
force-pushed
the
gitlab
branch
2 times, most recently
from
99d0ad9 to
1b8f2e8
Compare
erquhart
pushed a commit
that referenced
this pull request
Jan 4, 2018
Make contributor data available to hugo
tech4him1
force-pushed
the
gitlab
branch
2 times, most recently
from
99f68e3 to
c9d045e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.