Skip to content

use x_display_name #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

use x_display_name #1

merged 1 commit into from
Jan 27, 2023

Conversation

@vrunoa
Copy link
Contributor

@vrunoa vrunoa commented Jan 15, 2023

Update example in README.md as display_name makes the generate to fail. Seems like it needs to be x_display_name

$ buf generate api
$ api/v2/myservice.proto:15:9:service MyService: option (oapi.v1.service): field display_name not found

technicallyjosh
technicallyjosh approved these changes Jan 27, 2023
View reviewed changes
Copy link
Owner

@technicallyjosh technicallyjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@technicallyjosh technicallyjosh merged commit 7ceb820 into technicallyjosh:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@technicallyjosh technicallyjosh technicallyjosh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vrunoa @technicallyjosh