5 update business service #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified Product's ID attribute to comply with database RAW Id type
BS is operative now. Complying to the requirements. Changing the version to 1.0.0, although is not going tio be necessary. Added javadocs comments for documentation. Nice to have in the feature: *Availability to restore the stock using web browser cache, or something like that. Probably cookies of some sort.
Owner
Author
|
Seems okay to me 👍 |
jesus-mont
reviewed
Jun 17, 2025
jesus-mont
reviewed
Jun 17, 2025
src/main/java/com/encorazone/inventory_manager/domain/Product.java
Outdated
Show resolved
Hide resolved
jesus-mont
reviewed
Jun 17, 2025
jesus-mont
reviewed
Jun 17, 2025
src/main/java/com/encorazone/inventory_manager/service/ProductServiceImpl.java
Outdated
Show resolved
Hide resolved
jesus-mont
reviewed
Jun 17, 2025
src/main/java/com/encorazone/inventory_manager/controller/InventoryManagerController.java
Outdated
Show resolved
Hide resolved
jesus-mont
reviewed
Jun 17, 2025
src/main/java/com/encorazone/inventory_manager/service/FilteredSearch.java
Outdated
Show resolved
Hide resolved
eso31
reviewed
Jun 18, 2025
eso31
reviewed
Jun 18, 2025
src/main/java/com/encorazone/inventory_manager/service/FilteredSearch.java
Outdated
Show resolved
Hide resolved
eso31
reviewed
Jun 18, 2025
src/main/java/com/encorazone/inventory_manager/service/ProductServiceImpl.java
Outdated
Show resolved
Hide resolved
eso31
reviewed
Jun 18, 2025
src/main/java/com/encorazone/inventory_manager/service/ProductServiceImpl.java
Outdated
Show resolved
Hide resolved
eso31
reviewed
Jun 18, 2025
eso31
reviewed
Jun 18, 2025
Modified pom.xml: - Moved hardcoded versions to the properties block
Modified pom.xml: - Added lombok dependency (version:1.18.38) to manage getters & setters
Modified Product.java: - Deleted getters & setters - Enabled lombok dependency to keep the code clean - ...Next project will use ID instead of UUID
* Deleted application.properties * Created application.yml
* Deleted unused FilteredSearch.java. Following the YAGNI principle. Wasn´t needed
Modified ProductServiceImpl.java - Added method/logic to delete products. * Products are DELETED as no safe-delete was needed in this project
ProductServiceImpl.java: - Removed hardcoded value from updateStock method - Added condition to avoid a db call to save the same information ProductService.java & InventoryManagerController.java: - Updated method signatures to return a DTO to prevent exposing sensitive data. No multiple layers needed. ProductFilter.java: - Updated quantityEquals method to comply with client requests
Modified files: - ProductRepository.java: added definition to repository to make the necessary query - ProductMapper.java: Transform the InventorySummaryInterface from the repository method to a response appropriate data type for the endpoint. - InventoryService.java: added definition for the summary/metrics new method - InventoryServiceImpl.java: added implementation of the new method from the InventoryService.java - InventoryManagerController.java: added endpoint for summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend is now working as intended and required for the breakableToy 1
Nice to have in the future: