perf: not create instance

Author: technote-space

src/logic/ga/Algorithm/Ga.ts

@@ -1,6 +1,7 @@
-import {GeneticAlgorithmBase} from '@technote-space/ga-framework';
+import {GeneticAlgorithmBase} from '@technote-space/ga-framework/dist/app/logic/Algorithm';
 import {ITermination, IMigration} from '@technote-space/genetic-algorithms-js';
 import {Genotype} from '../Genotype';
+import {Phenotype} from '../Phenotype';
 import {Termination} from '../Termination';
 import {Migration} from '../Migration';
 import {UpdateResult, Context} from '../../types';
@@ -53,7 +54,7 @@ export abstract class Ga extends GeneticAlgorithmBase<UpdateResult> {
       population: this.chromosomes.map(chromosome => {
         const genotype = chromosome as Genotype;
         return {
-          value: genotype.phenotype.value,
+          value: Phenotype.getValue(genotype),
           fitness: genotype.fitness ?? 0,
         };
       }),

src/logic/ga/Crossovers/Cultural.ts

@@ -1,12 +1,24 @@
 import {CrossoverBase, IChromosome} from '@technote-space/genetic-algorithms-js';
+import {Genotype} from '../Genotype';
 
 export class Cultural extends CrossoverBase {
+  private _pool: Array<IChromosome> = [];
+
   public constructor(probability: number) {
     super(2, 2, probability);
+
+    [...Array(this.childrenNumber)].forEach(() => {
+      this._pool.push(new Genotype());
+    });
   }
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   protected performCross(parents: Array<IChromosome>, _probability: number): Array<IChromosome> {
-    return parents.flatMap(parent => parent.clone());
+    let index = 0;
+    parents.forEach(parent => {
+      this._pool[index++].copyFrom(parent);
+    });
+
+    return this._pool;
   }
 }

src/logic/ga/Crossovers/Mgg.ts

@@ -1,6 +1,9 @@
 import {CrossoverBase, IChromosome} from '@technote-space/genetic-algorithms-js';
+import {Genotype} from '../Genotype';
 
 export class Mgg extends CrossoverBase {
+  private _pool: Array<IChromosome> = [];
+
   public constructor(probability: number, private readonly mixProbability: number, private readonly crossoverTime: number) {
     super(2, crossoverTime * 2, probability);
 
@@ -9,15 +12,22 @@ export class Mgg extends CrossoverBase {
       this.mixProbability = 1 - mixProbability;
     }
     this.mixProbability = Math.min(Math.max(this.mixProbability, 0), 0.5);
+
+    [...Array(this.childrenNumber)].forEach(() => {
+      this._pool.push(new Genotype());
+    });
   }
 
   protected performCross(parents: Array<IChromosome>, probability: number): Array<IChromosome> {
     const parent1 = parents[0];
     const parent2 = parents[1];
 
-    return [...Array(this.crossoverTime)].flatMap(() => {
-      const child1 = parent1.clone();
-      const child2 = parent2.clone();
+    let index = 0;
+    [...Array(this.crossoverTime)].forEach(() => {
+      const child1 = this._pool[index++];
+      const child2 = this._pool[index++];
+      child1.copyFrom(parent1);
+      child2.copyFrom(parent2);
 
       if (probability > 0 && Math.random() < probability) {
         const len    = Math.min(parent1.length, parent2.length);
@@ -30,8 +40,8 @@ export class Mgg extends CrossoverBase {
           }
         }
       }
-
-      return [child1, child2];
     });
+
+    return this._pool;
   }
 }

src/logic/ga/Fitness.ts

@@ -1,6 +1,7 @@
 import {FitnessBase, IChromosome} from '@technote-space/genetic-algorithms-js';
 import levenshtein from 'fast-levenshtein';
 import {Genotype} from './Genotype';
+import {Phenotype} from './Phenotype';
 import {TestData} from './TestData/TestData';
 
 export class Fitness extends FitnessBase {
@@ -9,10 +10,9 @@ export class Fitness extends FitnessBase {
   }
 
   public evaluate(chromosome: IChromosome): void {
-    const genotype  = chromosome as Genotype;
-    const phenotype = genotype.phenotype;
+    const genotype = chromosome as Genotype;
 
-    const diff = levenshtein.get(this.testData.target, phenotype.value);
-    phenotype.setFitness(1.0 / (diff + 1));
+    const diff       = levenshtein.get(this.testData.target, Phenotype.getValue(genotype));
+    genotype.fitness = 1.0 / (diff + 1);
   }
 }

src/logic/ga/Genotype.ts

@@ -1,28 +1,20 @@
-import {Acid, ChromosomeBase} from '@technote-space/genetic-algorithms-js';
-import {Phenotype} from './Phenotype';
+import {Acid, ChromosomeBase, IChromosome} from '@technote-space/genetic-algorithms-js';
 
 export class Genotype extends ChromosomeBase {
-  private _phenotype: Phenotype | undefined = undefined;
+  protected _fitness: number;
 
   public constructor() {
     super(0, true);
+    this._fitness = -1;
     this.generateAcids();
   }
 
   public get fitness(): number {
-    return this.phenotype.fitness;
+    return this._fitness;
   }
 
-  public set fitness(_: number) {
-    //
-  }
-
-  public get phenotype(): Phenotype {
-    if (!this._phenotype) {
-      this._phenotype = new Phenotype(this);
-    }
-
-    return this._phenotype;
+  public set fitness(fitness: number) {
+    this._fitness = fitness;
   }
 
   public createNew(): ChromosomeBase {
@@ -40,4 +32,8 @@ export class Genotype extends ChromosomeBase {
   public getGenes(): Array<number> {
     return [...Array(this.length).keys()].map(index => Number(this.getAcid(index).value));
   }
+
+  protected performCopyFrom(_from: IChromosome): void {
+    this._fitness = _from.fitness;
+  }
 }

src/logic/ga/Phenotype.ts

@@ -2,22 +2,8 @@ import encoding from 'encoding-japanese';
 import {Genotype} from './Genotype';
 
 export class Phenotype {
-  protected _fitness: number;
-
-  public constructor(protected genotype: Genotype) {
-    this._fitness = -1;
-  }
-
-  public get fitness(): number {
-    return this._fitness;
-  }
-
-  public setFitness(fitness: number): void {
-    this._fitness = Math.max(0, fitness);
-  }
-
-  public get value(): string {
-    return encoding.convert(this.genotype.getGenes(), {
+  public static getValue(genotype: Genotype): string {
+    return encoding.convert(genotype.getGenes(), {
       to: 'UNICODE',
       type: 'string',
     }) as string;

src/logic/ga/Reinsertion/Mgg.ts

@@ -6,14 +6,15 @@ export class Mgg extends ReinsertionBase {
   }
 
   public select(population: Array<IChromosome>, offspring: Array<IChromosome>, parents: Array<IChromosome>): Array<IChromosome> {
+    const sortedOffspring: Array<IChromosome> = [...offspring];
     if (this.addParentsToOffspring) {
-      offspring.push(...parents);
+      sortedOffspring.push(...parents);
     }
-    offspring.sort((chromosome1, chromosome2) => (chromosome2.fitness ?? -1.0) - (chromosome1.fitness ?? -1.0));
+    sortedOffspring.sort((chromosome1, chromosome2) => (chromosome2.fitness ?? -1.0) - (chromosome1.fitness ?? -1.0));
 
     const selected = [...population];
-    selected.push(offspring.splice(0, 1)[0]); // elite
-    selected.push(this.take(offspring));
+    selected.push(sortedOffspring.splice(0, 1)[0]); // elite
+    selected.push(this.take(sortedOffspring));
 
     return selected;
   }