Skip to content

Conversation

@virgofx
Copy link
Member

@virgofx virgofx commented Nov 25, 2024

Changes

  • Simplified getAllTerraformModules() by removing workspace parameter and using workspaceDir from context
  • Added full test coverage for wiki.ts
  • Created sample fixtures for consistent wiki building tests
  • Updated several package dependencies to latest minor versions

Testing

  • Added comprehensive test suite for wiki.ts
  • Included fixtures to ensure consistent wiki generation
  • All existing tests passing

Impact

This change simplifies the module fetching logic by leveraging existing context, making the code more maintainable and easier - to test. The added test coverage ensures reliability of the wiki generation functionality.

@virgofx virgofx self-assigned this Nov 25, 2024
@virgofx virgofx added the documentation Improvements or additions to documentation label Nov 25, 2024
@virgofx virgofx force-pushed the feat/wiki-tests-and-refactor branch 14 times, most recently from a4c9660 to fad54bd Compare November 25, 2024 17:05
* Remove workspace parameter from getAllTerraformModules() in favor of context
* Add comprehensive test coverage for wiki.ts with fixtures
* Update minor package dependencies
@virgofx virgofx force-pushed the feat/wiki-tests-and-refactor branch from fad54bd to 13f70ee Compare November 25, 2024 17:06
@github-actions
Copy link

Release Plan

No terraform modules updated in this pull request.

✅ Wiki Check ℹ️

Note: The following Terraform modules no longer exist in source; however, corresponding tags/releases exist. Automation tag/release deletion is disabledno subsequent action will take place.

v1.3.1, v1.3.0, v1.2.0, v1.1.1, v1.1.0, v1.0.1, v1.0.0, v1

Powered by techpivot/terraform-module-releaser

@sonarqubecloud
Copy link

@virgofx virgofx merged commit d58113f into main Nov 25, 2024
25 checks passed
@virgofx virgofx deleted the feat/wiki-tests-and-refactor branch November 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants