Post job failure

[ddriddle]

If cache/MD5SUMS exists in the cache the following error occurs:

Post job cleanup.
EEXIST: file already exists, open 'cache/MD5SUMS'
Total files hashed 0.

See https://github.com/techservicesillinois/awscli-login/actions/runs/3161676314/jobs/5147533213

[edthedev]

Saw this again - here
https://github.com/techservicesillinois/awscli-login/actions/runs/3480771967/jobs/5821083741

Post job cleanup.
EEXIST: file already exists, open 'cache/MD5SUMS'
Total files hashed 0.

[edthedev]

An idea we had while discussing this - we could add a force-clear-cache flag of some sort, so folks using the plugin can force a clean cache when needed.

[ddriddle]

The problem is that GitHub is reporting a cache miss:

Run techservicesillinois/cache-validation@v1
  with:
    path: cache
    cache_hit: false
    remove_invalid_files: true
    touch: true
...
Cache miss: nothing to validate.

But there was a cache hit:

Received 59722579 of 59722579 (100.0%), 72.4 MBs/sec
Cache Size: ~57 MB (59722579 B)
/usr/bin/tar --use-compress-program unzstd -xf /home/runner/work/_temp/64d0dc4b-d4c1-400c-8426-6da5a9596c98/cache.tzst -P -C /home/runner/work/awscli-login/awscli-login
Cache restored successfully
Cache restored from key: Linux-3.8-tox-b6abe56[15](https://github.com/techservicesillinois/awscli-login/actions/runs/3480771967/jobs/5821083575#step:8:16)c7da8f30e3607bb651e382b834dfe2ef65d3f4cba12ff70a36e7d6a-46-2020-02-[16](https://github.com/techservicesillinois/awscli-login/actions/runs/3480771967/jobs/5821083575#step:8:17)Received 59722579 of 59722579 (100.0%), 72.4 MBs/sec
Cache Size: ~57 MB (59722579 B)
/usr/bin/tar --use-compress-program unzstd -xf /home/runner/work/_temp/64d0dc4b-d4c1-400c-8426-6da5a9596c98/cache.tzst -P -C /home/runner/work/awscli-login/awscli-login
Cache restored successfully
Cache restored from key: Linux-3.8-tox-b6abe56[15](https://github.com/techservicesillinois/awscli-login/actions/runs/3480771967/jobs/5821083575#step:8:16)c7da8f30e3607bb651e382b834dfe2ef65d3f4cba12ff70a36e7d6a-46-2020-02-[16](https://github.com/techservicesillinois/awscli-login/actions/runs/3480771967/jobs/5821083575#step:8:17)

That is why the post validate step fails because the MD5SUM file used for validation already exists. The POST validate refuses to change it and exits with an error:

Post job cleanup.
EEXIST: file already exists, open 'cache/MD5SUMS'
Total files hashed 0.

[ddriddle]

The GitHub API reports that the cache key recovered was generated for the default branch:

  $ curl \
  -H "Accept: application/vnd.github+json" \
  -H "Authorization: Bearer <YOUR-TOKEN>" \
  https://api.github.com/repos/techservicesillinois/awscli-login/actions/caches
  ...
    {
      "id": 3144,
      "ref": "refs/heads/master",
      "key": "Linux-3.8-tox-b6abe5615c7da8f30e3607bb651e382b834dfe2ef65d3f4cba12ff70a36e7d6a-46-2020-02-16",
      "version": "1c4574e63645e142b43de5838ae845ff9d2050b39d556ba823eef849802cb554",
      "last_accessed_at": "2022-11-16T15:34:07.126666700Z",
      "created_at": "2022-11-15T23:05:36.803333300Z",
      "size_in_bytes": 59722579
    },
  ...

https://docs.github.com/en/rest/actions/cache#get-github-actions-cache-usage-for-a-repository

[ddriddle]

This ticket is related to issue #16 and yanked PR #20.

[ddriddle]

In summary, the issue is that an exact cache match from the default branch (master) counts as a cache miss even though cached data is returned. It is similar to how the restore-keys works:

Note: cache-hit will be set to true only when cache hit occurs for the exact key match. For a partial key match via restore-keys or a cache miss, it will be set to false.
https://github.com/actions/cache

To fix the issue, I purpose that if an MD5SUM file exists we validate it even if cache-hit is set to false. We should also overwrite the MD5SUM because the contents of the cache will likely have changed, and add a flag to force remove the cache contents #24.

[ddriddle]

Note tag v1.0 points to v1.1.0. It should point to v1.1.3 the latest release. That will partially resolve this issue, since overwriting the MD5SUM was implemented in #20.

[ddriddle]

I tested the v1.1.3 release and it fixes the issue: https://github.com/techservicesillinois/awscli-login/actions/runs/3492275761/jobs/5845885511.

To fully resolve the issue cache validation should happen.