Firefox compatibility and many improvements #89

rafaelgomesxyz · 2018-12-03T13:15:38Z

Made the extension compatible with Firefox
Migrated the modules to E6 and implemented many E6 features
Migrated development to Webpack, because I'm more familiar with it than Gulp
Fixed the tests and migrated them to Mocha + Chai, because this combination allows for some cool testing features that Jasmine does not have
Added a PT-BR locale
Added an options menu, to allow users to opt-in to Google Analytics and Rollbar instead of making them enabled by default, which is a privacy concern since GDPR
Added an option to disable scrobbling in real time, in case the user wants to sync their history when they wish
Improved the loading time of the activity history, by loading things asynchronously and implementing a cache
Implemented a Google Sheets database for the history sync, so that if a user corrects an item all other users will receive suggestions for the same correction
Made it so that the sync checkbox is disabled if the item was not found on Trakt in the history sync, to prevent errors when syncing
Improved UI error handling when updating an item in the history sync (it now shows messages to the user to let them know what is going on)
Started using Netflix' API instead of scraping the HTML of the page to get information about the item that the user is watching
Made it so that requests to the Netflix API are made in English, which should allow the extension to work well for users using non-English Netflix most of the times
Improved the detection of episode titles
Fixed the detection of collections
...

- Improve episode title detection

- Add options menu - Various fixes and improvements

- Add PT-BR locale - Fix tests - Up version

# Conflicts: # README.md

- Add option to disable scrobbling (close #4)

- Disable sync checkbox if item was not found on Trakt (close #8) - Make sure that when 'Select all' is toggled, items that are disabled are not checked (close #9)

… on Firefox (close #10) - Migrate tests from Jasmine to Mocha + Chai (close #11) - v2.0.2

- Fix a bug that happens when updating shows (close #14)

coveralls · 2018-12-03T13:18:11Z

Coverage decreased (-22.7%) to 58.278% when pulling d85fddb on gsrafael01:master into 7d6b4d3 on tegon:master.

rafaelgomesxyz · 2018-12-03T13:20:05Z

Coverage decreasing is because of the new functionality that I haven't added tests for yet, but I can do that as well.

tegon · 2018-12-27T13:18:54Z

@gsrafael01 No problem, the test can be added in a new pull request if that's the case.

Since the changes are too big, I can't do a properly review so I'm going to accept the pull request and try the app later.

Thanks!

rafaelgomesxyz · 2018-12-27T16:35:07Z

There might be a few things to fix for it to fully work properly with Chrome though: #86 (comment) I'll see if I can perform some tests soon.

Gerst20051 · 2019-01-04T02:24:09Z

@tegon @gsrafael01 you guys rock! nice work getting this resolved! 💯 👍 💥

Gerst20051 · 2019-01-04T02:26:13Z

README.md

@@ -43,20 +46,20 @@ This extension only works with Netflix HTML player and new layout. If you are in
 See this link for more info: https://help.netflix.com/en/node/23742

 ### Problems
-If you find any problems or have suggestions or questions, feel free to [open an issue](https://github.com/tegon/traktflix/issues/new)
+If you find any problems or have suggestions or questions, feel free to [open an issue](https://github.com/gsrafael01/traktflix/issues/new)


this should probably be changed back to tegon to avoid confusion.

Gerst20051 · 2019-01-04T02:27:31Z

README.md

@@ -99,4 +109,7 @@ npm test
 This product uses the TMDb API but is not endorsed or certified by TMDb. <br>
 This product uses the Trakt.tv API.

+[tegon](https://github.com/user/tegon) is the original developer of this extension.
+Since it was not having many updates in the past year and was also removed from the Chrome store, I took it upon myself to work on it and finally port it to Firefox.


maybe this section can be converted to be a more generic section that lists contributors/maintainers.

Gerst20051 · 2019-01-04T02:28:59Z

package.json

+  "private": true,
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/gsrafael01 /traktflix.git"


this url should be updated

rafaelgomesxyz · 2019-01-04T03:36:48Z

I just released a new version that uses launchWebAuthFlow like the old version did: https://github.com/gsrafael01/traktflix/tree/2.0.6

I'm not sure how to make a PR for this. When I try making a PR it includes all of the commits that have already been merged. :S

gazpachoking · 2019-01-22T19:12:21Z

@gsrafael01 Your commits from this PR got squashed when merging, which is why they are showing up again when you try to make a new PR. You'll need to check out the latest from this repo, then apply your new changes to that.

rafaelgomesxyz · 2019-01-22T23:32:28Z

Thanks, @gazpachoking! I'll do that.

Rafael added 22 commits October 18, 2018 22:46

- Make extension compatible with Firefox

1dd2834

- Improve episode title detection

Update extension.zip

8711d49

- Migrate to Webpack

80fa031

- Add options menu - Various fixes and improvements

- Many bug fixes and enhancements

ffb7f35

- Add PT-BR locale - Fix tests - Up version

Update README.md

3302fdc

- Fix collections detection

7b868e9

Merge remote-tracking branch 'origin/master'

74e2923

Update README.md

414e802

- Use Netflix API instead of scraping the HTML (close #1)

849c08d

Merge remote-tracking branch 'origin/master'

003f280

# Conflicts: # README.md

- Improve loading time of activity history (closes #2)

3626667

- Fix webpack.config

049d45b

- Rename config.json.dev to config.dev.json

741022c

- Add Firefox to .travis.yml

0f4f017

- Possible fix for Travis

c7b4434

- Implement cache and database for history sync (close #3)

2212ea0

- Add option to disable scrobbling (close #4)

- Improve error handling when updating item in history sync (close #5)

389a65f

- Make requests to the Netflix API using English (close #7)

580c39e

- Disable sync checkbox if item was not found on Trakt (close #8) - Make sure that when 'Select all' is toggled, items that are disabled are not checked (close #9)

- v2.0.1

91c60d9

- Fix a bug that only triggers the extension when installing/updating…

82d1798

… on Firefox (close #10) - Migrate tests from Jasmine to Mocha + Chai (close #11) - v2.0.2

v2.0.3

b773a35

v2.0.4

d85fddb

- Fix a bug that happens when updating shows (close #14)

tegon merged commit fbc8807 into tegon:master Dec 27, 2018

Gerst20051 reviewed Jan 4, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firefox compatibility and many improvements #89

Firefox compatibility and many improvements #89

rafaelgomesxyz commented Dec 3, 2018

coveralls commented Dec 3, 2018

rafaelgomesxyz commented Dec 3, 2018

tegon commented Dec 27, 2018

rafaelgomesxyz commented Dec 27, 2018 •

edited

Loading

Gerst20051 commented Jan 4, 2019

Gerst20051 Jan 4, 2019

Gerst20051 Jan 4, 2019

Gerst20051 Jan 4, 2019

rafaelgomesxyz commented Jan 4, 2019

gazpachoking commented Jan 22, 2019

rafaelgomesxyz commented Jan 22, 2019

Firefox compatibility and many improvements #89

Firefox compatibility and many improvements #89

Conversation

rafaelgomesxyz commented Dec 3, 2018

coveralls commented Dec 3, 2018

rafaelgomesxyz commented Dec 3, 2018

tegon commented Dec 27, 2018

rafaelgomesxyz commented Dec 27, 2018 • edited Loading

Gerst20051 commented Jan 4, 2019

Gerst20051 Jan 4, 2019

Choose a reason for hiding this comment

Gerst20051 Jan 4, 2019

Choose a reason for hiding this comment

Gerst20051 Jan 4, 2019

Choose a reason for hiding this comment

rafaelgomesxyz commented Jan 4, 2019

gazpachoking commented Jan 22, 2019

rafaelgomesxyz commented Jan 22, 2019

rafaelgomesxyz commented Dec 27, 2018 •

edited

Loading