New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox compatibility and many improvements #89

Merged
merged 22 commits into from Dec 27, 2018

Conversation

Projects
None yet
4 participants
@gsrafael01
Copy link
Contributor

gsrafael01 commented Dec 3, 2018

  • Made the extension compatible with Firefox
  • Migrated the modules to E6 and implemented many E6 features
  • Migrated development to Webpack, because I'm more familiar with it than Gulp
  • Fixed the tests and migrated them to Mocha + Chai, because this combination allows for some cool testing features that Jasmine does not have
  • Added a PT-BR locale
  • Added an options menu, to allow users to opt-in to Google Analytics and Rollbar instead of making them enabled by default, which is a privacy concern since GDPR
  • Added an option to disable scrobbling in real time, in case the user wants to sync their history when they wish
  • Improved the loading time of the activity history, by loading things asynchronously and implementing a cache
  • Implemented a Google Sheets database for the history sync, so that if a user corrects an item all other users will receive suggestions for the same correction
  • Made it so that the sync checkbox is disabled if the item was not found on Trakt in the history sync, to prevent errors when syncing
  • Improved UI error handling when updating an item in the history sync (it now shows messages to the user to let them know what is going on)
  • Started using Netflix' API instead of scraping the HTML of the page to get information about the item that the user is watching
  • Made it so that requests to the Netflix API are made in English, which should allow the extension to work well for users using non-English Netflix most of the times
  • Improved the detection of episode titles
  • Fixed the detection of collections
  • ...

gsrafael01 added some commits Oct 19, 2018

- Make extension compatible with Firefox
- Improve episode title detection
- Migrate to Webpack
- Add options menu
- Various fixes and improvements
- Many bug fixes and enhancements
- Add PT-BR locale
- Fix tests
- Up version
- Implement cache and database for history sync (close #3)
- Add option to disable scrobbling (close #4)
- Make requests to the Netflix API using English (close #7)
- Disable sync checkbox if item was not found on Trakt (close #8)
- Make sure that when 'Select all' is toggled, items that are disabled are not checked (close #9)
- Fix a bug that only triggers the extension when installing/updating…
… on Firefox (close #10)

- Migrate tests from Jasmine to Mocha + Chai (close #11)
- v2.0.2
v2.0.4
-  Fix a bug that happens when updating shows (close #14)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage decreased (-22.7%) to 58.278% when pulling d85fddb on gsrafael01:master into 7d6b4d3 on tegon:master.

@gsrafael01

This comment has been minimized.

Copy link
Contributor

gsrafael01 commented Dec 3, 2018

Coverage decreasing is because of the new functionality that I haven't added tests for yet, but I can do that as well.

@tegon

This comment has been minimized.

Copy link
Owner

tegon commented Dec 27, 2018

@gsrafael01 No problem, the test can be added in a new pull request if that's the case.

Since the changes are too big, I can't do a properly review so I'm going to accept the pull request and try the app later.

Thanks!

@tegon tegon merged commit fbc8807 into tegon:master Dec 27, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-22.7%) to 58.278%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gsrafael01

This comment has been minimized.

Copy link
Contributor

gsrafael01 commented Dec 27, 2018

There might be a few things to fix for it to fully work properly with Chrome though: #86 (comment) I'll see if I can perform some tests soon.

@Gerst20051

This comment has been minimized.

Copy link

Gerst20051 commented Jan 4, 2019

@tegon @gsrafael01 you guys rock! nice work getting this resolved! 💯 👍 💥

@@ -43,20 +46,20 @@ This extension only works with Netflix HTML player and new layout. If you are in
See this link for more info: https://help.netflix.com/en/node/23742

### Problems
If you find any problems or have suggestions or questions, feel free to [open an issue](https://github.com/tegon/traktflix/issues/new)
If you find any problems or have suggestions or questions, feel free to [open an issue](https://github.com/gsrafael01/traktflix/issues/new)

This comment has been minimized.

@Gerst20051

Gerst20051 Jan 4, 2019

this should probably be changed back to tegon to avoid confusion.

@@ -99,4 +109,7 @@ npm test
This product uses the TMDb API but is not endorsed or certified by TMDb. <br>
This product uses the Trakt.tv API.

[tegon](https://github.com/user/tegon) is the original developer of this extension.
Since it was not having many updates in the past year and was also removed from the Chrome store, I took it upon myself to work on it and finally port it to Firefox.

This comment has been minimized.

@Gerst20051

Gerst20051 Jan 4, 2019

maybe this section can be converted to be a more generic section that lists contributors/maintainers.

"private": true,
"repository": {
"type": "git",
"url": "git://github.com/gsrafael01 /traktflix.git"

This comment has been minimized.

@Gerst20051

Gerst20051 Jan 4, 2019

this url should be updated

@gsrafael01

This comment has been minimized.

Copy link
Contributor

gsrafael01 commented Jan 4, 2019

I just released a new version that uses launchWebAuthFlow like the old version did: https://github.com/gsrafael01/traktflix/tree/2.0.6

I'm not sure how to make a PR for this. When I try making a PR it includes all of the commits that have already been merged. :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment