-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official Helm Chart #1542
Comments
There is not plan for an official helm chart that I know of. We are working on providing a operator (see That said, it might make sense to have one ? /kind question |
@MLBMatt i wrote an helm chart with pipeline and dashboard. My plan was to add triggers before making it public. I also wrote an helm chart for prow so that I can set up my full ci/cd solution from helm. It’s not official though, but I will be happy to contribute if there is some interest for it. |
@MLBMatt i made the repo public, but keep in mind it's still work in progress. Things are subject to change as i work on it. https://github.com/eddycharly/helm-prow-tekton/tree/master/helm/tekton |
@vdemeester i think having a helm chart is great to simplify installation for the end user. It is also useful for documenting how one can configure/customize the installation, while allowing to provide default values. Things like adding custom annotations, labels, tuning resources, etc... are so common, that's where helm really shines. |
What I really need is just a way to apply the CRDs automatically into a cluster...right now we're just leveraging a makefile to run a "setup task" that runs a bunch of |
The crds and the controller are tightly coupled. What do you mean by « just a way to apply the crds into a cluster » ? The chart can deploy only the crds and controller. Dashboard and webhook components are optional and can be disabled. |
Like I need the |
I agree that an officially maintained chart would be great. A lot of charts are created and maintained by the community though. |
I'm also contemplating a chart, but it seems like if its not part of the official repo and build process, it will quickly fall behind as issues / features are implemented and released. It looks like IBM has a community chart that's already defunct. https://github.com/IBM/charts/tree/master/community/tekton-pipelines An official chart is certainly valuable, and doable, but i think we'd have to come up with a sensible set of parameters that can be adjusted and those would somehow have to be injected in the proper places in the new templates. But looking at the configs https://github.com/tektoncd/pipeline/tree/master/config it seems as though the are not dynamically generated or compiled into the releases, so it might make sense to just helm-ify those directly suggest users prefer Helm ala GitHub repo.
I think if you take that approach, you can also generate release yaml using Helm dry-run / debug to simply output default values from the templates in their current inline form. This also seems to be agnostic from the rest of the project concerns, eg, the controller code, etc. So would be non-disruptive and would allow both a chart based and kubectl based installation from the same codebase. |
Linking issue in plumbing tektoncd/plumbing#278 This is WIP. |
@vdemeester or someone.. is there any update on this front? |
@salaboy we couldn't integrate this in the official org, i've setup one repo here https://github.com/eddycharly/tekton-helm but it's not official |
ended up here by search for issues. +1 for an official helm chart support. |
An update on here, I am currently using Jenkins X Helm Charts which include and maintain a Tekton Helm Chart for their deployments, so it is up to date:
I hope this helps... |
@salaboy Is this the chart you are referring to https://github.com/jenkins-x-charts/tekton ? |
@ibexmonj yes, I think that those are the charts that are published in their public helm chart repository linked above. |
fwiw, it looks like Helm 3 has made a conscious decision to not fully support CRDs, so its likely not a good idea to pursue a Tekton chart. https://helm.sh/docs/chart_best_practices/custom_resource_definitions/ |
@adjavaherian thats not what i interpret based on the what the docs say. They are handling CRD installs in a separate directory now I believe there is value in adding the community chart and let the community maintain it under the official project like other open source projects do. FWIW, there are already at least 2 separate work streams i have found that are maintaining the tekton helm charts |
@adjavaherian I do understand that it gets confusing for updates of CRDs, but are Tekton CRDs changing that much? I mean, if they are stable enough for other projects to consume, I think that having a Helm chart is very useful, |
@salaboy yeah makes sense to me. FWIW the Jenkins X helm chart is currently a little behind the latest release https://github.com/jenkins-x-charts/tekton/blob/0ead7a1b6d950aedb303df76b0ece90fac66a71d/tekton/values.yaml#L2. It would be great to setup some automation and keep up-to-date with latest releases including automated testing that could also help provide the tekton project some feedback too. If the CDF has the infrastructure to be able to do this then that sounds like a win, I'd happily help any way I can. |
@salaboy @rawlingsj great thinking - I'll take it to the CDF interoperability SIG (https://github.com/cdfoundation/sig-interoperability) and I'm sure we can get this done somehow or the other. |
To date, the operator looks to be under development and refactoring (for instance, I had a look two days ago, and the 'deploy' dir was renamed to 'config' between 2 pages reload). And, I suppose, this operator would require the OLM (Operator Lifecycle Manager). I guess not everyone has got this OLM installed / available (even if easily installable). So, in the meantime, I would suggest to rely on a Helm chart. Personally, I succeeded in using the charts provided by @eddycharly (and could make PR to use the latest version of pipelines and dashboard). |
So, the goal of |
@imjasonh perfect.. let me send a PR there. |
Would it make more sense for the Operator to have a helm chart instead of just pipelines? |
What do you mean by that ? 🤔 By Operator, I assume you don't mean |
@vdemeester I do! There's no easy way to deploy the Tekton Operator yaml and the Config yaml without running kubectl from a local machine. A really simple helm chart that would install the operator on a cluster and allow you to choose which install config profile you wanted "basic, default, all" would be really helpful. I could use the HashiCorp Terraform Helm Provider to install the operator rather than what I do now. Download a local copies of the install yaml and config yaml into my IAC repo then deploy them with a third party Terraform Provider that can apply yaml files. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale |
Yeah that could work tbh. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
@vince-franco At present, 2 ways to install Tektoncd/operator are:
I think providing a helm chart for operator will be an improvement compared to the available options, as it would help us leverage an existing popular tool. However, I think separate helm chart for individual Tektoncd Components (pipeline, triggers, chains) etc, is not good way to solve go. As this could create unnecessary overhead in the release/maitenance of components. |
/remove-lifecycle stale |
FYI this chart has not been updated in a while and does not include 0.27.3 which means that the chart currently does not install on k8s 1.22. We found this out the hard way.. |
Thank you for the heads up. Initially, our idea is to support customizations such as:
|
Suggestion: please make sure that the Helm chart also supports customizing the operator image(s), see #610. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I can't seem to find an official Tekton Pipelines helm chart. It looks like the JX team has their own implementation of it but it looks tuned to JX. Is there any plan (or one that currently exists) for an officially supported Helm chart?
The text was updated successfully, but these errors were encountered: