Remove deprecated podSpec field in favor of podTemplate 🛄 #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
|
/lgtm not sure why the tests are having a hard time with it |
|
@sbwsg I think I missed something 😅 |
We introduced `podTemplate` in last release to specify podSpec specific field, and deprecated `nodeSelector`, `tolerations` and `affinity`. This removes those deprecated fields. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
1070-remove-deprecated-podspec-fields
branch
from
7268b02
to
9445a45
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
Fixes #1070 |
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Feb 23, 2022
This picks up go-containerregistry PRs tektoncd#1299 and tektoncd#1300, which fix bugs in auth config handling introduced since k8schain previously depended on Kubenetes credentialprovider code. These breakags affect auth configs where the registry string included the URL scheme ("https://", "http://"), and when the string included the registry path component ("/v1/" or "/v2/") -- these should be ignored, and the broken code did not ignore them.
tekton-robot
pushed a commit
that referenced
this pull request
Feb 24, 2022
This picks up go-containerregistry PRs #1299 and #1300, which fix bugs in auth config handling introduced since k8schain previously depended on Kubenetes credentialprovider code. These breakags affect auth configs where the registry string included the URL scheme ("https://", "http://"), and when the string included the registry path component ("/v1/" or "/v2/") -- these should be ignored, and the broken code did not ignore them.
afrittoli
pushed a commit
to afrittoli/pipeline
that referenced
this pull request
Feb 25, 2022
This picks up go-containerregistry PRs tektoncd#1299 and tektoncd#1300, which fix bugs in auth config handling introduced since k8schain previously depended on Kubenetes credentialprovider code. These breakags affect auth configs where the registry string included the URL scheme ("https://", "http://"), and when the string included the registry path component ("/v1/" or "/v2/") -- these should be ignored, and the broken code did not ignore them.
tekton-robot
pushed a commit
that referenced
this pull request
Feb 25, 2022
This picks up go-containerregistry PRs #1299 and #1300, which fix bugs in auth config handling introduced since k8schain previously depended on Kubenetes credentialprovider code. These breakags affect auth configs where the registry string included the URL scheme ("https://", "http://"), and when the string included the registry path component ("/v1/" or "/v2/") -- these should be ignored, and the broken code did not ignore them.
khrm
pushed a commit
to openshift/tektoncd-pipeline
that referenced
this pull request
May 19, 2022
This picks up go-containerregistry PRs tektoncd#1299 and tektoncd#1300, which fix bugs in auth config handling introduced since k8schain previously depended on Kubenetes credentialprovider code. These breakags affect auth configs where the registry string included the URL scheme ("https://", "http://"), and when the string included the registry path component ("/v1/" or "/v2/") -- these should be ignored, and the broken code did not ignore them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We introduced
podTemplatein last release to specify podSpec specificfield, and deprecated
nodeSelector,tolerationsandaffinity.This removes those deprecated fields.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task and TaskRun to build and release this image
Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes