-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test/logs helper binary in favor of tkn ⚓ #1414
Remove test/logs helper binary in favor of tkn ⚓ #1414
Conversation
`tkn` is already released and can display logs as much as this helper. So let's remove this code and use a released version of tkn instead. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
/lgtm niiiice |
Depends on tektoncd/plumbing#83 |
tektoncd/plumbing#83 is in, now needs to build, publish and update the image in prow 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Similar to tektoncd/pipeline#1414, now that tkn is in the test-runner image, drop the custom logger in favour of tkn {} logs.
Similar to tektoncd/pipeline#1414, now that tkn is in the test-runner image, drop the custom logger in favour of tkn {} logs.
Changes
tkn
is already released and can display logs as much as thishelper. So let's remove this code and use a released version of tkn
instead.
/cc @bobcatfish @afrittoli
How do you prefer to install
tkn
binary in the test image ?tektoncd/plumbing
; this would maketkn
available for all the projects 😉Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.