Enhance the cluster resource type a bit. #1466
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
docs/resources.md
Outdated
| gcloud container clusters describe <cluster-name> --format='value(endpoint)' | ||
| ``` | ||
|
|
||
| Then, create a secret with this information and use it as described above. |
There was a problem hiding this comment.
Can you distill this advice into a single easily-copypasteable script?
ENDPOINT=$(gcloud container clusters describe ${CLUSTER_NAME} --format='value=(endpoint)')
kubectl create sercret generic ${SECRET_NAME} \
--from-literal=endpoint=${ENDPOINT} \
...
There was a problem hiding this comment.
I'll do that for the secret, but the endpoint actually goes into the resource directly under url. I'll show that with a smaller example I guess.
There was a problem hiding this comment.
How's this? I stopped short of a full cat << EOF to create the secret and resource.
I was trying it out with a GKE cluster, and noticed a few issues: - we require a username for everything, even if we're using CA auth. - we weren't checking token auth. This should really be switched to a declarative system where resources can specify optional params, but that can come as part of the larger refactor. This makes things a bit nicer tot use in the meantime.
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-build-tests |
I was trying it out with a GKE cluster, and noticed a few issues:
This should really be switched to a declarative system where resources can
specify optional params, but that can come as part of the larger refactor.
This makes things a bit nicer tot use in the meantime.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes