Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add securityContext to run as root for kaniko example 🤖 #1560

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

vdemeester
Copy link
Member

Changes

As of today, kaniko assumes it is running as root, which means, this
example fails on platform that default to run containers as random
uid (like OpenShift). Adding this securityContext make it explicit that
it needs to run as root.

Related to #1551 (although it doesn't fully fix it as, for OpenShift, to run as root, you need anyuid 😅)

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

As of today, kaniko assumes it is running as root, which means, this
example fails on platform that default to run containers as random
uid (like OpenShift). Adding this securityContext make it explicit that
it needs to run as root.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2019
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 12, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Nov 12, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Nov 12, 2019

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@tekton-robot tekton-robot merged commit 6522a26 into tektoncd:master Nov 12, 2019
@vdemeester vdemeester deleted the kaniko-assumes-root branch November 12, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants