Run TestReconcileTimeouts as separate tests ⏰ #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that these tests are setup to run as separate test cases but weren't using the t.Run functionality that lets them actually be treated as separate test cases. Added t.Run so that one test case failing will not prevent the others from running and failures will be reported separately.
bobcatfish
added
the
kind/cleanup
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
pritidesai
reviewed
Jul 29, 2020
| c := testAssets.Controller | ||
| clients := testAssets.Clients | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| d := test.Data{ |
There was a problem hiding this comment.
we need similar refactoring here 😿, the ones we did in PR #2876 and may be share some of the common functions 🤔
There was a problem hiding this comment.
When I work on separating common functions like we discussed in PR #2876, I will try and see if its possible to refactor taskrun_test.go
|
/test pull-tekton-pipeline-integration-tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I noticed that these tests are setup to run as separate test cases but
weren't using the t.Run functionality that lets them actually be treated
as separate test cases. Added t.Run so that one test case failing will
not prevent the others from running and failures will be reported
separately.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes