Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main branch for community repository 🧙 #3747

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

vdemeester
Copy link
Member

Changes

… instead of master branch. The default branch of the
tektoncd/community repository is now main. This should fix the CI as
it was defaulting to master when cloning tektoncd/community.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind cleanup
/cc @tektoncd/core-maintainers

Related to tektoncd/plumbing#681

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot requested a review from a team February 3, 2021 18:11
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
I think we can skip changes to docs in vendor though?

… instead of `master` branch. The default branch of the
tektoncd/community repository is now `main`. This should fix the CI as
it was defaulting to `master` when cloning `tektoncd/community`.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Copy link
Member Author

Thanks for this!
I think we can skip changes to docs in vendor though?

Yep fixed.. I didn't noticed I was changing files in vendor when doing this.. 😅

@pritidesai
Copy link
Member

thanks a bunch @vdemeester for quick fix 👍
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@imjasonh
Copy link
Member

imjasonh commented Feb 3, 2021

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@tekton-robot tekton-robot merged commit 9850785 into tektoncd:master Feb 3, 2021
@vdemeester vdemeester deleted the community-main branch February 4, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants