Skip to content

Conversation

@nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 20, 2023

Proposed changes

Fix the package release workflow to build the correct version.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 added bug Something isn't working ci/cd Improvements or additions to the CI/CD process labels Oct 20, 2023
@nfelt14 nfelt14 requested a review from a team as a code owner October 20, 2023 18:04
@nfelt14 nfelt14 temporarily deployed to package-build October 20, 2023 18:04 — with GitHub Actions Inactive
@nfelt14 nfelt14 requested a review from a team October 20, 2023 18:04
@nfelt14 nfelt14 enabled auto-merge (squash) October 20, 2023 18:06
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #38 (13d02d9) into main (babf12e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3757      3757           
  Branches       646       646           
=========================================
  Hits          3757      3757           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14 nfelt14 disabled auto-merge October 20, 2023 18:24
@nfelt14 nfelt14 enabled auto-merge (squash) October 20, 2023 18:28
@nfelt14 nfelt14 merged commit 072287c into main Oct 20, 2023
@nfelt14 nfelt14 deleted the nfelt14/ensure-releasing-latest-version branch October 20, 2023 18:51
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
* ci: Update release workflow to checkout the latest tip of main to ensure the correct version is being built.

* docs: Update template to mark the commit messages as safe in order to prevent pre-commit from failing when it tries to convert HTML escape sequences.
Signed-off-by: v12ganesh ganesh.v@tektronix.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/cd Improvements or additions to the CI/CD process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants