Skip to content

Conversation

@jharajeev55
Copy link
Contributor

No description provided.

@jharajeev55 jharajeev55 requested a review from esarver September 30, 2025 10:44
@jharajeev55 jharajeev55 self-assigned this Sep 30, 2025
@jharajeev55 jharajeev55 added the bug Something isn't working label Sep 30, 2025
@jharajeev55 jharajeev55 requested a review from a team as a code owner September 30, 2025 10:44
@jharajeev55 jharajeev55 added the enhancement New feature or request label Sep 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Summary

Summary
Generated on: 10/03/2025 - 15:30:52
Coverage date: 10/03/2025 - 15:28:36
Parser: Cobertura
Assemblies: 15
Classes: 40
Files: 40
Line coverage: 8.9% (317 of 3550)
Covered lines: 317
Uncovered lines: 3233
Coverable lines: 3550
Total lines: 6142
Branch coverage: 5.1% (33 of 636)
Covered branches: 33
Total branches: 636
Method coverage: Feature is only available for sponsors
Tag: 52_18226580965

Coverage

kic-script-gen.src.back_end - 0%
Name Line Branch
kic-script-gen.src.back_end 0% 0%
kic-script-gen.src.back_end.client_server.rs 0% 0%
kic-script-gen.src.back_end.data_model.rs 0% 0%
script-aggregator.src - 0%
Name Line Branch
script-aggregator.src 0% 0%
script-aggregator.src.indent_engine.rs 0% 0%
script-aggregator.src.script_buffer.rs 0% 0%
script-gen-manager.src - 0%
Name Line Branch
script-gen-manager.src 0% 0%
script-gen-manager.src.catalog.rs 0%
script-gen-manager.src.device.rs 0% 0%
script-gen-manager.src.instr_metadata - 0%
Name Line Branch
script-gen-manager.src.instr_metadata 0% ****
script-gen-manager.src.instr_metadata.base_metadata.rs 0%
script-gen-manager.src.instr_metadata.enum_metadata.rs 0%
script-gen-manager.src.instr_metadata.mpsu50_metadata.rs 0%
script-gen-manager.src.instr_metadata.msmu60_metadata.rs 0%
script-gen-manager.src.model.chan_data - 0%
Name Line Branch
script-gen-manager.src.model.chan_data 0% 0%
script-gen-manager.src.model.chan_data.bias_channel.rs 0% 0%
script-gen-manager.src.model.chan_data.channel_range.rs 0% 0%
script-gen-manager.src.model.chan_data.default_channel.rs 0% 0%
script-gen-manager.src.model.chan_data.region_map.rs 0% 0%
script-gen-manager.src.model.chan_data.start_stop_channel.rs 0% 0%
script-gen-manager.src.model.chan_data.step_channel.rs 0%
script-gen-manager.src.model.chan_data.sweep_channel.rs 0%
script-gen-manager.src.model.sweep_data - 0%
Name Line Branch
script-gen-manager.src.model.sweep_data 0% 0%
script-gen-manager.src.model.sweep_data.global_parameters.rs 0%
script-gen-manager.src.model.sweep_data.number_limit.rs 0% 0%
script-gen-manager.src.model.sweep_data.parameters.rs 0% 0%
script-gen-manager.src.model.sweep_data.status_msg.rs 0%
script-gen-manager.src.model.sweep_data.step_sweep_config.rs 0%
script-gen-manager.src.model.sweep_data.sweep_config.rs 0% 0%
script-gen-manager.src.model.sweep_data.sweep_model.rs 0%
script-gen-manager.src.model.sweep_data.sweep_timing_config.rs 0%
script-gen-manager.src.script_component - 0%
Name Line Branch
script-gen-manager.src.script_component 0% 0%
script-gen-manager.src.script_component.data_report.rs 0%
script-gen-manager.src.script_component.finalize.rs 0%
script-gen-manager.src.script_component.function.rs 0% 0%
script-gen-manager.src.script_component.initialize.rs 0% 0%
script-gen-manager.src.script_component.script.rs 0% 0%
script-gen-manager.src.script_component.sweep.rs 0% 0%
xml-handler.src - 0%
Name Line Branch
xml-handler.src 0% ****
xml-handler.src.generic_parser.rs 0%
xml-handler.src.composite - 25%
Name Line Branch
xml-handler.src.composite 25% 8.8%
xml-handler.src.composite.mod.rs 25% 8.8%
xml-handler.src.condition - 70.9%
Name Line Branch
xml-handler.src.condition 70.9% 50%
xml-handler.src.condition.mod.rs 70.9% 50%
xml-handler.src.group - 41.6%
Name Line Branch
xml-handler.src.group 41.6% 14.2%
xml-handler.src.group.mod.rs 41.6% 14.2%
xml-handler.src.resources - 0%
Name Line Branch
xml-handler.src.resources 0% ****
xml-handler.src.resources.mod.rs 0%
xml-handler.src.snippet - 44.3%
Name Line Branch
xml-handler.src.snippet 44.3% 50%
xml-handler.src.snippet.mod.rs 44.3% 50%
xml-handler.src.substitute - 71.4%
Name Line Branch
xml-handler.src.substitute 71.4% ****
xml-handler.src.substitute.mod.rs 71.4%
xml-handler.src.variable - 63.6%
Name Line Branch
xml-handler.src.variable 63.6% 58.8%
xml-handler.src.variable.mod.rs 75.6% 58.3%
xml-handler.src.variable.sub_mod.rs 48.9% 60%

@jharajeev55 jharajeev55 marked this pull request as draft September 30, 2025 10:54
@jharajeev55 jharajeev55 marked this pull request as ready for review September 30, 2025 11:05
Copy link
Member

@esarver esarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the commented code and I'll approve.

…nderstand and implemented , we will try to handle this limit if its required

Also correcting SMU limit for overrange case
@jharajeev55 jharajeev55 requested a review from esarver October 3, 2025 12:26
@jharajeev55 jharajeev55 merged commit 074496a into main Oct 3, 2025
16 checks passed
@jharajeev55 jharajeev55 deleted the fxi/TSP-1170-correct-source-limit-for-smu-and-psu branch October 3, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants