feat(rover-ctl): add EventSpec handler, env placeholder substitution, and HTTP client improvements by ron96g · Pull Request #264 · telekom/controlplane

ron96g · 2026-03-05T09:03:49Z

Add EventSpecification handler with JSON schema resolution and file:// ref support
Introduce ${VAR} placeholder substitution in resource files during parsing
Add static header HTTP client wrapper with User-Agent and local access token support
Replace port subscription type with event subscription type in Rover handler
Fix ensureCorrectBasePath to treat "/" as empty and stop polling on failed state

… and HTTP client improvements - Add EventSpecification handler with JSON schema resolution and file:// ref support - Introduce ${VAR} placeholder substitution in resource files during parsing - Add static header HTTP client wrapper with User-Agent and local access token support - Replace port subscription type with event subscription type in Rover handler - Fix ensureCorrectBasePath to treat "/" as empty and stop polling on failed state

Copilot

Pull request overview

This PR extends rover-ctl with support for EventSpecification resources, introduces ${VAR} environment placeholder substitution during YAML/JSON parsing, and improves HTTP client behavior (static headers/User-Agent + local token support) alongside a few handler/poller fixes.

Changes:

Add placeholder substitution (${VAR}) to the parser and tests for placeholder behavior and parsing.
Add an EventSpecification handler with JSON schema $ref resolution (including file:// references) and register it.
Add a static-header HTTP client wrapper and update readiness polling/base path handling.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
rover-ctl/pkg/parser/testdata/placeholder-resource.yaml	New test resource containing `${VAR}` placeholders.
rover-ctl/pkg/parser/placeholders_test.go	Unit tests for placeholder substitution behavior.
rover-ctl/pkg/parser/placeholders.go	Implements `${VAR}` environment substitution with unresolved-variable errors.
rover-ctl/pkg/parser/parser_test.go	Integration tests verifying placeholder substitution during file parsing.
rover-ctl/pkg/parser/parser.go	Applies placeholder substitution during file parse; preserves filename property without relying on `*os.File`.
rover-ctl/pkg/handlers/v0/rover_test.go	Updates rover subscription tests from `port` to `eventType`.
rover-ctl/pkg/handlers/v0/rover.go	Updates subscription patching logic to detect `eventType` subscriptions.
rover-ctl/pkg/handlers/v0/eventspec.go	New EventSpecification handler with JSON schema parsing and `file://` `$ref` support.
rover-ctl/pkg/handlers/registry.go	Registers the new EventSpecification handler.
rover-ctl/pkg/handlers/common/status_poller.go	Stops polling on `failed` processing state as well as `done`.
rover-ctl/pkg/handlers/common/httpclient.go	Adds static header HTTP client wrapper (`WithStaticHeaders`).
rover-ctl/pkg/handlers/common/base_handler.go	Adds User-Agent header and optional local access-token path for HTTP client setup.
rover-ctl/pkg/config/token.go	Treats expected base path of `/` as empty.
rover-ctl/pkg/config/config.go	Adds `access.token` default (env: `ROVER_ACCESS_TOKEN`).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ient, and status poller

…directly from spec map

BjoernKarma

LGTM

The only question in my mind was whether or not to use a standard library for the env variable replacement. But I think for our purpose the custom implementation works good and it is already very well covered with tests.

lukas016 · 2026-03-10T14:10:56Z

 	ext := strings.ToLower(filepath.Ext(filePath))

-	file, err := os.OpenFile(filePath, os.O_RDONLY, 0o644)
+	content, err := os.ReadFile(filePath)


i can send you big file and it will be whole allocated in memory. Do you have some extra protection above?

This will run client-side anyways and there is a request-size-limit on server-side, so I dont think this should be a big issue. Normally these files are fairly small anyways

lukas016 · 2026-03-10T14:12:29Z

 	}
-	defer file.Close()
+
+	content, err = SubstitutePlaceholders(content)


cannot Env variables affect json or yaml format? shouldn't be replace logic be executed after parsing or do you need replace some values in middle of string or keys?

If someone puts some invalid stuff in there which breaks the parsing, then its their problem. The idea of this feature is just to allow secrets aka strings to be replaced and that should not be a big issue imo

# [0.18.0](v0.17.0...v0.18.0) (2026-03-18) ### Bug Fixes * **common-server:** race-condition and security improvements ([#272](#272)) ([9d08e02](9d08e02)) * **gateway:** add deny-all sentinel to ACL plugin when no consumers exist ([#277](#277)) ([0dd6017](0dd6017)) ### Features * **common-libs:** improve error handling, add feature flags, and fix logger type ([#260](#260)) ([03165a0](03165a0)) * **common-server:** unify latency format in logs ([#267](#267)) ([5fbb19e](5fbb19e)) * **gateway:** add buffering config, dynamic upstream, access control fix, and secret-manager integration ([#259](#259)) ([719c58f](719c58f)) * introduce event-driven communication to the control plane ([#265](#265)) ([f1ed1f5](f1ed1f5)) * **rover-ctl:** add EventSpec handler, env placeholder substitution, and HTTP client improvements ([#264](#264)) ([f15e0f7](f15e0f7)) * **rover-ctl:** support for get-info-many cmd ([#246](#246)) ([1d9f194](1d9f194)) * **secret-manager:** add write strategy support and improve caching ([#263](#263)) ([3f311bf](3f311bf))

ron96g marked this pull request as ready for review March 5, 2026 09:06

Copilot AI review requested due to automatic review settings March 5, 2026 09:06

Copilot started reviewing on behalf of ron96g March 5, 2026 09:06 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

fix(rover-ctl): address review findings in EventSpec handler, HTTP cl…

7193b4c

…ient, and status poller

ron96g requested review from BjoernKarma, iagarba, julius-malcovsky, lukas016 and stefan-ctrl March 5, 2026 11:59

ron96g added enhancement New feature or request go Pull requests that update go code rover Anything related to the rover domain event-pubsub labels Mar 5, 2026

fix(rover-ctl): update PatchEventSpecificationRequest to set content …

5242868

…directly from spec map

BjoernKarma approved these changes Mar 6, 2026

View reviewed changes

lukas016 reviewed Mar 10, 2026

View reviewed changes

Comment thread rover-ctl/pkg/parser/parser.go

lukas016 reviewed Mar 10, 2026

View reviewed changes

Merge branch 'main' into feature/rover-ctl-changes

86b5ae7

ron96g merged commit f15e0f7 into main Mar 11, 2026
312 of 314 checks passed

ron96g deleted the feature/rover-ctl-changes branch March 11, 2026 13:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rover-ctl): add EventSpec handler, env placeholder substitution, and HTTP client improvements#264

feat(rover-ctl): add EventSpec handler, env placeholder substitution, and HTTP client improvements#264
ron96g merged 4 commits into
mainfrom
feature/rover-ctl-changes

ron96g commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BjoernKarma left a comment

Uh oh!

Uh oh!

lukas016 Mar 10, 2026

Uh oh!

ron96g Mar 11, 2026

Uh oh!

lukas016 Mar 10, 2026

Uh oh!

ron96g Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ron96g commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BjoernKarma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lukas016 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

ron96g Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

lukas016 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

ron96g Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants